From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Wed, 13 Sep 2017 19:27:29 +0200 Message-ID: <87o9qezeym.fsf@mouse.gnus.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505323692 25335 195.159.176.226 (13 Sep 2017 17:28:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Sep 2017 17:28:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 28402@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 13 19:28:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsBSJ-0006UY-Jf for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Sep 2017 19:28:07 +0200 Original-Received: from localhost ([::1]:43809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsBSR-0007Dx-0Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Sep 2017 13:28:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsBSH-0007CS-BE for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:28:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsBSD-0008VP-Uw for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:28:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsBSD-0008V6-RQ for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dsBSD-0002oH-K3 for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2017 13:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2017 17:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150532365610769 (code B ref 28402); Wed, 13 Sep 2017 17:28:01 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 13 Sep 2017 17:27:36 +0000 Original-Received: from localhost ([127.0.0.1]:38641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsBRo-0002nc-Kx for submit@debbugs.gnu.org; Wed, 13 Sep 2017 13:27:36 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:56034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsBRm-0002nL-SL for 28402@debbugs.gnu.org; Wed, 13 Sep 2017 13:27:35 -0400 Original-Received: from cm-84.209.243.26.getinternet.no ([84.209.243.26] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dsBRh-0000R4-Fc; Wed, 13 Sep 2017 19:27:31 +0200 In-Reply-To: (Vasilij Schneidermann's message of "Sat, 9 Sep 2017 21:39:39 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136900 Archived-At: Vasilij Schneidermann writes: > I'm using shr.el for a package and override `shr-tag-img` by let-binding > `shr-external-rendering-functions` to an alist containing an alternative > rendering function that deals better with local images. Despite this > `shr-tag-img` is still directly called when rendering tables with images > inside them. I think it would be nice to alter those direct calls to heed `shr-external-rendering-functions'. Doesn't seem to be much potential for performance degradation that I can see... Perhaps introduce a helper function like `(shr-indirect-call 'img child)' or something... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no