From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable Date: Sat, 28 Oct 2017 15:48:17 -0400 Message-ID: <87o9orawam.fsf@users.sourceforge.net> References: <878tu9wk53.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509220157 1989 195.159.176.226 (28 Oct 2017 19:49:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Oct 2017 19:49:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Dmitri Paduchikh , 24573@debbugs.gnu.org To: Win Treese Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 28 21:49:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8X6P-0007fD-1L for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Oct 2017 21:49:05 +0200 Original-Received: from localhost ([::1]:33824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8X6W-00007N-4z for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Oct 2017 15:49:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8X6P-00007E-V9 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 15:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8X6M-0007Qb-Qj for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 15:49:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8X6M-0007QL-MJ for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 15:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e8X6M-0005G7-EF for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 15:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2017 19:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24573 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24573-submit@debbugs.gnu.org id=B24573.150922010620166 (code B ref 24573); Sat, 28 Oct 2017 19:49:02 +0000 Original-Received: (at 24573) by debbugs.gnu.org; 28 Oct 2017 19:48:26 +0000 Original-Received: from localhost ([127.0.0.1]:39496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8X5m-0005FC-60 for submit@debbugs.gnu.org; Sat, 28 Oct 2017 15:48:26 -0400 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:46225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8X5k-0005Ev-NZ for 24573@debbugs.gnu.org; Sat, 28 Oct 2017 15:48:25 -0400 Original-Received: by mail-io0-f180.google.com with SMTP id 101so19324867ioj.3 for <24573@debbugs.gnu.org>; Sat, 28 Oct 2017 12:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wvhcqOiJNkoe2zeNYXoJdOSDZfpThBiVpA2PYTXqVXI=; b=s/Yl0IdHpQLz6wqvo/QrNwjAwNjlMrfYavzYoyBLRc7juCzDOL3vm+gHFJ6CuI5SYV 4Un3EDh02GYCngWfCHO2DSGtqVADh2Uxe5La2YTKsmQYMFyxkVPSi2UsnX7czkKVuier 1mXeQT1HLHlcNIV44cSUcLxfYnAjf4K/TdZc5qc9fbf/hoXWEFbH4LjaPIgTpBpJQxMh O7Qu5YL2egv38+e4c+Sr4baiXx1cej5w3obamjSqZvTFOCGC9NTapJ9K4tVOMcNTTURR sDxQLrcrZpQIwmL/hOOg5vIA0MU8ujbpU43sLfT+TYTM5r3wIQtU8JhcJytpWptwPDdY nrkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=wvhcqOiJNkoe2zeNYXoJdOSDZfpThBiVpA2PYTXqVXI=; b=DHs6Gypz5nvjP0vIDPMkJ+KLBXoZqLciNInzTeUCTAmIZXKitiRH7d0UtXOFfE1Z1g bLyxp26bARTLJ1i303zuBEAnsLMHRTFbRcafhHL8gYihweTBwk1fCrCpf5sFcVj1aS+D LkW3d3WG2UVJN+AvzhEEkt0HX3v+DvWlEie5hnjWnuPGh2nqIyqmhhlUOLHxOOT8tkRC aZ9T+2t02wcOVluhI7w3SWhGULdAlfmi+USDQTn90gtqDeGL2WWsYjCN9f4/sfm68vqe 5pk+QnyAC3R3HJ+EYm2wS1+uUImeEKBE5hwAuxwnAt+rYS5sbQV7LLDSKl8WKt9QXEaO T8IQ== X-Gm-Message-State: AMCzsaURbNvopohjR6h/R14m9V6eiFV9Pp6TCaXIl3KO+JadUq0pCQ02 1QGhjMxl2kR5QsRqP5cJyFc= X-Google-Smtp-Source: ABhQp+Qo0ALFQZGDe605NqCac0L8+PEUelxjucGLDh2gYIIXNlnERJ6DwNgyrfeYGNKXh9Pfj3ikgg== X-Received: by 10.107.178.12 with SMTP id b12mr5069014iof.234.1509220098988; Sat, 28 Oct 2017 12:48:18 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e81sm4614503ioi.15.2017.10.28.12.48.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Oct 2017 12:48:18 -0700 (PDT) In-Reply-To: (Win Treese's message of "Sat, 28 Oct 2017 14:53:59 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139127 Archived-At: Win Treese writes: > Finding the problem: > > The problem appears to be in the definition for describe-function i > help-fns.el. help-setup-xref is called with a lambda instead of a > function symbol (as it was before this code was changed). > When the bookmark is saved, the syntax for the lambda is not > parsable by read to restore it. The lambda is fine, it's the buffer which uses the unreadable print synax: #<...>. The following which swaps buffer objects with their name seems to fix it, although I haven't really tested this much. --- i/lisp/help-mode.el +++ w/lisp/help-mode.el @@ -756,7 +756,9 @@ help-bookmark-make-record (error "Cannot create bookmark - help command not known")) `(,@(bookmark-make-record-default 'NO-FILE 'NO-CONTEXT) (help-fn . ,(car help-xref-stack-item)) - (help-args . ,(cdr help-xref-stack-item)) + (help-args . ,(mapcar (lambda (a) + (if (bufferp a) (buffer-name a) a)) + (cdr help-xref-stack-item))) (position . ,(point)) (handler . help-bookmark-jump)))