From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29156: 25.3; eshell/kill does not understand - Date: Sun, 05 Nov 2017 07:38:37 -0500 Message-ID: <87o9og7vea.fsf@users.sourceforge.net> References: <87vaiprmg5.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509885564 13334 195.159.176.226 (5 Nov 2017 12:39:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Nov 2017 12:39:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29156@debbugs.gnu.org To: Pierre Neidhardt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 05 13:39:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBKCj-0002bD-Ph for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 13:39:09 +0100 Original-Received: from localhost ([::1]:43982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBKCr-0003Vr-5t for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 07:39:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBKCf-0003VH-EC for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 07:39:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBKCc-00025F-9b for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 07:39:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBKCc-000259-6E for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 07:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBKCb-0003fO-RV for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 07:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2017 12:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29156-submit@debbugs.gnu.org id=B29156.150988552714072 (code B ref 29156); Sun, 05 Nov 2017 12:39:01 +0000 Original-Received: (at 29156) by debbugs.gnu.org; 5 Nov 2017 12:38:47 +0000 Original-Received: from localhost ([127.0.0.1]:51313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBKCM-0003eo-Qw for submit@debbugs.gnu.org; Sun, 05 Nov 2017 07:38:47 -0500 Original-Received: from mail-it0-f47.google.com ([209.85.214.47]:56811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBKCL-0003eX-71; Sun, 05 Nov 2017 07:38:45 -0500 Original-Received: by mail-it0-f47.google.com with SMTP id r127so2192319itb.5; Sun, 05 Nov 2017 04:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZYE7lsXoholcm6jd1eJliTvGhKwNWwer4YgcsAq6fJs=; b=UpUjlXVJlLAi5eewXwoO9kzQF9EmHBckCbjM/dU2linkkgmHmD3Hn3aMrGI0OGwFKr LlctSLFRlnmVvZdEuvEYddbwNPWq+DUPo1b6SZuE56+mItdZeH+d2jR3kC7vTzm4ftQ1 iagppJADd4sMREMwjchrpNNE0Hhz35wEN/R9BbjaC2YH60uXE11tDSx8d/fMNwgWoZz1 Am45B+9TPLJTnrLSLS/IkueEIrjzbhezrvM1pATglNEkD00GrVhN3Uz0LuITg09EmMX5 8uqkgEVzLtssMbSwfFl205yt87BETncpa8mVaceljfDODd3jj+6gIr9myZkHRVtuik/K gNCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ZYE7lsXoholcm6jd1eJliTvGhKwNWwer4YgcsAq6fJs=; b=ATXupwQFlTUxRJ0823hcSE1ll7agTvj14xMySDMNO9IvAuJblApIsjc/NORpm1wZqg g/fovr1Aw4AqYsbbyOAnq0qBuuQ/KKoTd64nrgXOkhVrBBayrb66wGrhusrj0zWAJArX DNUrIp53RlxTpaFygztpdX3r1DmgkJUuCXUgd3nTsnMKfcRML+oRbAjUUJUoQTFyl4kS lrhAcCWqxEhPII4C+VYbKooM9qc4KJGoaQYeBJOrknrGOUtLlrcvnhCnUhaEBuYoz+Re kdl5cyIYW+QVcIKW/pMUV0dLT9hN73SsrcKS46eyxciJ8c+W3YqjvsS4VeW+0nB89tEb nP0Q== X-Gm-Message-State: AJaThX5sceGHbFjw6qNNGVoOLyVHREQqoAOQntAcZiHIE4rCfscMBUAw 2SWw+WSMlDPIV/D3eyR9RG9qlA== X-Google-Smtp-Source: ABhQp+RpbBLqlqCTIJQ3OP7xrLt4fTqsRXlZgekYBBkYHm1pB00KZrsIFohdnQFZpa3t1kxo9w8N2g== X-Received: by 10.36.254.140 with SMTP id w134mr5680452ith.73.1509885519445; Sun, 05 Nov 2017 04:38:39 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m145sm3438096itg.4.2017.11.05.04.38.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 04:38:38 -0800 (PST) In-Reply-To: <87vaiprmg5.fsf@gmail.com> (Pierre Neidhardt's message of "Sun, 05 Nov 2017 12:31:38 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144042 tags 29156 + confirmed quit Pierre Neidhardt writes: > - emacs -Q > - M-x eshell > > ~ $ kill -9 emacs > kill: bad pid: -9 This bit converts the "-9" into an integer: (defun eshell-lisp-command (object &optional args) ... ;; if any of the arguments are flagged as numbers ;; waiting for conversion, convert them now (unless (get object 'eshell-no-numeric-conversions) (while args (let ((arg (car args))) (if (and (stringp arg) (> (length arg) 0) (not (text-property-not-all 0 (length arg) 'number t arg))) (setcar args (string-to-number arg)))) (setq args (cdr args)))) ... Whereas this bit expects "-9" as a string: (defun eshell/kill (&rest args) ... (when (stringp arg) (cond ((string-match "\\`-[[:digit:]]+\\'" arg) (setq signum (abs (string-to-number arg)))) ((string-match "\\`-\\([[:upper:]]+\\|[[:lower:]]+\\)\\'" arg) (setq signum (abs (string-to-number arg))))) ... Using "-SIGKILL" doesn't work either, because eshell/kill calls `string-to-number' on it, giving 0. Apparently nobody ever actually used this feature before.