From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#23623: Patch to improve function options in find-func.el Date: Mon, 06 Nov 2017 20:03:38 -0500 Message-ID: <87o9oe6gt1.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510016660 19940 195.159.176.226 (7 Nov 2017 01:04:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Nov 2017 01:04:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 23623@debbugs.gnu.org To: Robert Weiner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 07 02:04:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBsJJ-0004pf-FJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Nov 2017 02:04:13 +0100 Original-Received: from localhost ([::1]:50902 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBsJO-0000jm-D3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 20:04:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBsJD-0000i2-73 for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 20:04:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBsJ9-0007lm-Tk for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 20:04:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBsJ9-0007lX-Pm for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 20:04:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBsJ7-00065x-MR for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 20:04:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2017 01:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23623-submit@debbugs.gnu.org id=B23623.151001662823410 (code B ref 23623); Tue, 07 Nov 2017 01:04:01 +0000 Original-Received: (at 23623) by debbugs.gnu.org; 7 Nov 2017 01:03:48 +0000 Original-Received: from localhost ([127.0.0.1]:54943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBsIu-00065W-AZ for submit@debbugs.gnu.org; Mon, 06 Nov 2017 20:03:48 -0500 Original-Received: from mail-io0-f176.google.com ([209.85.223.176]:48613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBsIs-00065J-OP for 23623@debbugs.gnu.org; Mon, 06 Nov 2017 20:03:47 -0500 Original-Received: by mail-io0-f176.google.com with SMTP id d66so397817ioe.5 for <23623@debbugs.gnu.org>; Mon, 06 Nov 2017 17:03:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3kIDb1iagPdlcxlQg79FMkyN1eXWK1g9mKuiLaf88i8=; b=b0OJEPQXtrEIRaww2Lmu20jp//bWqM9AtQ85RjcitotFlv0rtGBYsIwNgQxDHk6g/r poxB0v2N2UnYelcNxDPGuMQm6BNagkfT8yV/2gMU2Eke14wCRB27NcNVd4DpB5NncPe4 tEWX7e8Sbh0ILWXprMl+0af2ueBDx600H39cb+r+FwnxhIMSemX4N7Yl6hyfNe6GLArt up/SPmZTkiSi1756eryST/3XFG+1meLdTvCe/KXtJ9pBUAsRX8VvP1YYg4mpgUmn1qeU 4ktUi45OY7lL3DZ4NQ8AdeIFhAoXYn+LoyI88zCG/VHCjTVYSmPTmzoEvrValaE3Hp6c yVUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=3kIDb1iagPdlcxlQg79FMkyN1eXWK1g9mKuiLaf88i8=; b=hhK+EL5qeRNXtZhYvFQb5qXM+ADvXFntX3/I0l1/b5oKrozeOR1ib8rmd41eFsTEGj jKRyiI+zsW0NiSZ+YSwXusVOSYyNgrW9vKprdg5EQLlhKKepCldz1SDqkKFnxjGyH/s3 tXtcQDTSsLsfdDD5WT66z69xRmki1g7OE5kISgTNM48XVH2TY9iTKCGToPV6iYFJqMCv vqI7Re5xysVWVMbixrZx3b0tGWOLijfWoJhx4r0x+L218zxjOEPuIEEhZbCHb0yB3K7w 8CZyKKj6AbTTiUQeWUoQgKQWwls31wG3R2jOUXpZ/YzQfD07HIgGehx6aNaucJ5/QpxW myaQ== X-Gm-Message-State: AJaThX6R036asnoHzi9p/TkwvmzEo0gL0mNBMouIioxEKv6TtKrBnQhZ jNuNkOTn7tA2Ui4PTvjgfaolKQ== X-Google-Smtp-Source: ABhQp+SnKBkgdOB94njt6rFztwxvkqBCfa0ULrdmtMZtiYAMdoolQoxh0QxqDIgsgr/o3/THr/rUpA== X-Received: by 10.107.20.130 with SMTP id 124mr21570648iou.36.1510016620970; Mon, 06 Nov 2017 17:03:40 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e89sm5909928itd.3.2017.11.06.17.03.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Nov 2017 17:03:39 -0800 (PST) In-Reply-To: (Robert Weiner's message of "Thu, 26 May 2016 11:52:09 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139543 Archived-At: Robert Weiner writes: > Note that the one large patch section of one function is really just a > change of a line at the end of the function but diff generated a large > context patch for it, maybe the indentation changed. The patch seems to have got mangled by some line wrapping and similar. Please send as attachment instead. Please don't post to both emacs-devel and bug-gnu-emacs. > Please let me know if these changes are acceptable. They provide many > benefits to potential callers of this package and make the *-noselect > functions more straightforward to use. I think it's okay for master. > +Visit the library in a buffer, and return a (buffer . position) pair, The convention we use in docstrings is that placeholders in structures should be in upper case. The way you wrote it here would be describing a function which does (cons 'buffer 'position).