From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29156: 25.3; eshell/kill does not understand -, [PATCH] Make eshell/kill handle - and - Date: Fri, 16 Mar 2018 20:21:46 -0400 Message-ID: <87o9jnv9et.fsf@gmail.com> References: <87vaiprmg5.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="==-=-=" X-Trace: blaine.gmane.org 1521246013 24762 195.159.176.226 (17 Mar 2018 00:20:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Mar 2018 00:20:13 +0000 (UTC) Cc: Eric Skoglund , Pierre Neidhardt To: 29156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 17 01:20:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewzZv-0006Jp-92 for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 01:20:07 +0100 Original-Received: from localhost ([::1]:60124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewzby-00046N-Au for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Mar 2018 20:22:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewzbq-000462-2X for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:22:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewzbm-0000wu-SX for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:22:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57754) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewzbm-0000wP-Lu for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewzbm-0000a1-Eg for bug-gnu-emacs@gnu.org; Fri, 16 Mar 2018 20:22:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87vaiprmg5.fsf@gmail.com> Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Mar 2018 00:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 29156-submit@debbugs.gnu.org id=B29156.15212461172216 (code B ref 29156); Sat, 17 Mar 2018 00:22:02 +0000 Original-Received: (at 29156) by debbugs.gnu.org; 17 Mar 2018 00:21:57 +0000 Original-Received: from localhost ([127.0.0.1]:37418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewzbh-0000Zg-4k for submit@debbugs.gnu.org; Fri, 16 Mar 2018 20:21:57 -0400 Original-Received: from mail-it0-f45.google.com ([209.85.214.45]:54541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewzbd-0000ZP-0W for 29156@debbugs.gnu.org; Fri, 16 Mar 2018 20:21:53 -0400 Original-Received: by mail-it0-f45.google.com with SMTP id w3-v6so4065423itc.4 for <29156@debbugs.gnu.org>; Fri, 16 Mar 2018 17:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=MrCvn+rnPEk78QNVcBrFyAF5hUlZfhBuXQ9g35BO8yE=; b=INorllDN/8AGVqxz8USUHChE4Imz9K3hsgVdhYpO413QzphLlripCbNF5lDbEaML9H qcouH1fKkIhSG9PVO4e+E/dXDcLKpCvxc6fLHzDlZG2BHR8dtOl9tLM+bYcAblTis1DI VmKrsZwyNjKADvVkWk++VUNKISDkcjHlyf0Re32M2an61ePSlgeNemRzc5pm8/LkwOYL yoyKmOU+5NwMF4VpRv43xHxA1hjcqpeYuIewlwQPwSQjg+5pqkw/hIqPXxiX4nTbRpAm QRmV5nPFvgFygPMx6e2bXee4TTfaSlX5pcYMNq95Jv5WpAapIjOc3TDWC9KKmA4frfWe H82A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=MrCvn+rnPEk78QNVcBrFyAF5hUlZfhBuXQ9g35BO8yE=; b=qvHT4GeIFUTm88g7iH/Jm6Xr2Lbq8ZhtTJm3RurhZSAzO+KHZxw7sZG6kjMnJfmIsV 6AmzlOxS68BIrMCcy2i/XR0By7HBTNF2Lxn32SucIy881pnV0LNhiVNZSpJA9PfW+8Ks TYJLBf3JUVNn0Jjc+90kNpHIvgov1lDrNoY87lG+qv5TNQzYu/I4q+/Gli87WIoRey+H gcVqcawPxHZ9O2oKHlOaVrwpVweFN1FfxjnBP/dNNjGYIitAIiDlzS8+1KZZwggiEx+f /y3GUxk21abdlMxEfuX9ydRWzydP/yY9rKoDVvryJPxOvuxdMGT39sNCDWCv0IgyJFI1 cfmQ== X-Gm-Message-State: AElRT7Gqw7le69cic/qEe8N2/qiNBqZqqSn8FnOpDiMaW4aNtTYGL+Wh zwBR58beZc/W70EtuOGN2xk= X-Google-Smtp-Source: AG47ELsibjQ4KsHiv7SB3qT3BEd5pSuwcILifteXmLUGaAMfz0MUdg/AVqOD1jnxE0QErvPlTdfQHw== X-Received: by 2002:a24:98d6:: with SMTP id n205-v6mr4285143itd.130.1521246107531; Fri, 16 Mar 2018 17:21:47 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o75-v6sm5314219ito.15.2018.03.16.17.21.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Mar 2018 17:21:46 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144349 Archived-At: --==-=-= Content-Type: text/plain [forwarding to list] --==-=-= Content-Type: message/rfc822 Content-Disposition: inline From: Eric Skoglund To: Noam Postavsky Subject: Re: bug#29156: 25.3; eshell/kill does not understand - References: <87vaiprmg5.fsf@gmail.com> <87o9og7vea.fsf@users.sourceforge.net> Date: Fri, 16 Mar 2018 15:01:32 +0100 In-Reply-To: <87o9og7vea.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sun, 05 Nov 2017 07:38:37 -0500") Message-ID: <87fu50ktkz.fsf@pagefault.se> X-Headers-End: 1ewpvP-00GZmT-2I MIME-Version: 1.0 Content-Type: text/plain --=-=-= Content-Type: text/plain First time contributor. Here's a patch that allows eshell/kill to handle both the -9 case and the -SIGKILL case. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Make-eshell-kill-handle-signal-and-SIGNALNAME.patch Content-Description: eshell/kill patch >From 2789c82b27cfac175d6d04260db78a54a2f26b01 Mon Sep 17 00:00:00 2001 From: Eric Skoglund Date: Fri, 16 Mar 2018 14:49:56 +0100 Subject: [PATCH] Make eshell/kill handle - and - * lisp/eshell/esh-proc.el: Handle - and - --- lisp/eshell/esh-proc.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/eshell/esh-proc.el b/lisp/eshell/esh-proc.el index b3bd7a7245..6dab6636b0 100644 --- a/lisp/eshell/esh-proc.el +++ b/lisp/eshell/esh-proc.el @@ -178,12 +178,12 @@ eshell/kill ((string-match "\\`-[[:digit:]]+\\'" arg) (setq signum (abs (string-to-number arg)))) ((string-match "\\`-\\([[:upper:]]+\\|[[:lower:]]+\\)\\'" arg) - (setq signum (abs (string-to-number arg))))) + (setq signum (make-symbol (substring arg 1 (length arg)))))) (setq args (cdr args)))) (while args (let ((arg (if (eshell-processp (car args)) (process-id (car args)) - (car args)))) + (string-to-number (car args))))) (when arg (cond ((null arg) -- 2.13.6 --=-=-=-- --==-=-=--