From: Damien Cassou <damien@cassou.me>
To: 31191@debbugs.gnu.org
Subject: bug#31191: 26.1; [PATCH] Improve docstring of start-process-shell-command
Date: Tue, 17 Apr 2018 13:39:33 +0200 [thread overview]
Message-ID: <87o9iijc3u.fsf@cassou.me> (raw)
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
* lisp/subr.el (start-process-shell-command): Add recommended
signature to docstring. This hides the argument ARGS whose use is
discouraged. This also makes the argument COMMAND visible so the
user understands what the docstring is referring to.
--
Damien Cassou
http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Improve-docstring-of-start-process-shell-command.patch --]
[-- Type: text/x-patch, Size: 1135 bytes --]
From 912261c8dfb337c6f94ca81a495a3690c0628f1e Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Mon, 16 Apr 2018 16:06:36 +0200
Subject: [PATCH] Improve docstring of start-process-shell-command
* lisp/subr.el (start-process-shell-command): Add recommended
signature to docstring. This hides the argument ARGS whose use is
discouraged. This also makes the argument COMMAND visible so the
user understands what the docstring is referring to.
---
lisp/subr.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/subr.el b/lisp/subr.el
index 9cf7d596cd..59bac5a195 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3107,7 +3107,9 @@ start-process-shell-command
An old calling convention accepted any number of arguments after COMMAND,
which were just concatenated to COMMAND. This is still supported but strongly
-discouraged."
+discouraged.
+
+\(fn NAME BUFFER COMMAND)"
(declare (advertised-calling-convention (name buffer command) "23.1"))
;; We used to use `exec' to replace the shell with the command,
;; but that failed to handle (...) and semicolon, etc.
--
2.14.3
next reply other threads:[~2018-04-17 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 11:39 Damien Cassou [this message]
2018-04-17 11:43 ` bug#31191: 26.1; [PATCH] Improve docstring of start-process-shell-command Noam Postavsky
2018-04-17 12:44 ` Damien Cassou
2018-04-17 13:06 ` Noam Postavsky
2018-04-17 13:45 ` Damien Cassou
2018-04-17 22:44 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9iijc3u.fsf@cassou.me \
--to=damien@cassou.me \
--cc=31191@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).