From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.bugs Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame Date: Sun, 01 Jul 2018 20:56:00 +0000 Message-ID: <87o9fqy8tb.fsf@gmail.com> References: <87po2gkxpi.fsf@gmail.com> <87sh57yrax.fsf@gmail.com> <83lgawmwup.fsf@gnu.org> <878t6wxbzr.fsf@gmail.com> <5B38994B.2010605@gmx.at> <87va9zxfhe.fsf@gmail.com> <83in5zkjsk.fsf@gnu.org> <87tvpiyjz6.fsf@gmail.com> <83fu12lwh2.fsf@gnu.org> <83efgmlvya.fsf@gnu.org> <87r2kmyikh.fsf@gmail.com> <7ac98ea5-23c8-456a-8c40-18c703bea617@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530478506 29289 195.159.176.226 (1 Jul 2018 20:55:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2018 20:55:06 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 31325@debbugs.gnu.org, monnier@iro.umontreal.ca To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 01 22:55:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZjN7-0007VG-EC for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 22:55:01 +0200 Original-Received: from localhost ([::1]:55629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZjPE-0004Wo-L8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 16:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZjP7-0004Wj-Nw for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 16:57:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZjP4-00027Q-L0 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 16:57:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34515) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZjP4-00027G-GN for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 16:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fZjP4-0007Hd-36 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 16:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jul 2018 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31325-submit@debbugs.gnu.org id=B31325.153047857027899 (code B ref 31325); Sun, 01 Jul 2018 20:57:02 +0000 Original-Received: (at 31325) by debbugs.gnu.org; 1 Jul 2018 20:56:10 +0000 Original-Received: from localhost ([127.0.0.1]:42412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZjOD-0007Fv-T3 for submit@debbugs.gnu.org; Sun, 01 Jul 2018 16:56:10 -0400 Original-Received: from mail-qt0-f173.google.com ([209.85.216.173]:32875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZjOC-0007Fc-70 for 31325@debbugs.gnu.org; Sun, 01 Jul 2018 16:56:08 -0400 Original-Received: by mail-qt0-f173.google.com with SMTP id l10-v6so12325534qtj.0 for <31325@debbugs.gnu.org>; Sun, 01 Jul 2018 13:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=yV9hxmseLjuwQk8m7yHkJj3UTB8FYrUui6poCJAzOrA=; b=ARWjKEgGCj0KJHSWrXZfXNHSdNqtdfvUrpKL2aW8t1dMnGV/tT3zc20zrbCz3i+bRl 8UAQZ7Gg4MqUzk3V7+udnH/7lk8+l/OKjfA3fPdIYzUqP1DbCOr6ItkmWG16VLj2F7DN fi5fGWwACkNoI9i+ZHv49wlB2s+yOVLUvyPbvt3nkSbazoZqybrmDNZw5pLH1HAONojl 0RylANfkFFLW9UPvO/nh9VUM6iDHk/2dVgJsDE6pgl6bEINtl+ub3smlbEXQendQJQgL qfI+iWl/I/cl4jrUawK/NPN3F0sA2KvaJDJ2q9yNGPdktk6xk4vkfEOqW8N6XwEtCJ+z YAYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=yV9hxmseLjuwQk8m7yHkJj3UTB8FYrUui6poCJAzOrA=; b=Uvpx31JN29tkt/PGoAKK1s96r14jgcxvd40KsEFm/B/K83JdCd2NKRcVWdk+XynC9Y rP/eRPTm45eDs5JfbH+SD8aEwMRorZci8sgGr86uqL+zuQN+vxPD0sK91nNDOUc4ciY3 Olk3k2eFkcOiLVsfvdaz+zMJHgPCwku2jIQsWwC/LEDPo18DPoLGUJ9fMvwcgC4VGfnU x8UAn6utr08qibuSI97anktH9HlFL/PjreqSabL0JW7AyQSGO7uxKc3Loltm3zm+RdRN dwA1bMltyVuBNMao1BkK6EOtJ1Xq4+0u5zrDvSxAAZjO5BzEq9plIDbUsba598+YIFKB hPew== X-Gm-Message-State: APt69E3L5WFXdV/U67DjpJeVmOuH+C+1v7NDo6Ce7BBanK9+s8zi5Mne +7o9yoMew/o85A5KlZUgkJ0= X-Google-Smtp-Source: AAOMgpfH36BviSRXZFR0at5GfL8z4k72YnuUgW+DKTAG+0SECP3K1rNo3lwbeSx4ixLhpJC8QNXggw== X-Received: by 2002:a0c:e90c:: with SMTP id a12-v6mr5394797qvo.224.1530478562243; Sun, 01 Jul 2018 13:56:02 -0700 (PDT) Original-Received: from 9a50e8462956 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id 140-v6sm6527783qkm.18.2018.07.01.13.56.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 13:56:01 -0700 (PDT) In-reply-to: <7ac98ea5-23c8-456a-8c40-18c703bea617@default> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148064 Archived-At: Drew Adams writes: > Sorry, but I've not been following this bug thread. > I took only a (very) quick look at it, at > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31325. > > It looks like you are changing the default behavior of > `recenter', which is a backward-incompatible change. That's right but only for non-interactive uses of `recenter'. All interactive uses should remain backward compatible. > Am I right about that, so that all Lisp calls of that > function would now need to be changed, to add a non-nil > 2nd arg in order to keep the same behavior? That's right but only if the caller need to redisplay the frame. Are you aware of any lisp calls that make use of that feature (i.e. redisplay the frame as well as recenter) ? I'm only aware of two uses in Flycheck and `xref-find-definitions'. IMHO, in both cases the redisplay side-effect is undesirable. > The reported bug was only about a problem for Emacs in > a terminal, right? Can't it just be fixed to DTRT in > that case, without changing so much in the definition > and behavior of the function? I am not sure what does the right thing mean in this case. AFAIK, the patch was trying to do the right thing by keeping the interactive use backward compatible but prevent calling `recenter' from lisp from redisplaying the frame. > And in the old days people used Emacs mainly (and > originally, only) in the terminal. Why is the terminal > behavior suddenly considered to be bugged? Or given > that it is bugged - is changing the default behavior > the best fix? I only use Emacs from the terminal, in fact I compile emacs `without-x` since I never use the GUI. > Please ignore, if my understanding is wrong or my > comments on this are not helpful. I think it is very valuable to have more feedback on the patch. That said, I am still having trouble understanding what are your concerns. Cheers,