bug#29657: rcirc does not retain the server alias on reconnect

bug#29657: rcirc does not retain the server alias on reconnect

[Miciah Dashiel Butler Masters]

[-- Attachment #1.1: Type: text/plain, Size: 464 bytes --]

rcirc does not retain the server alias on reconnect.  As a result, rcirc
fails to re-use server and channel buffers when an alias is used.  Further
problems may ensue when aliases are used to differentiate multiple
connections to the same host, for example when using a single IRC bouncer
or proxy to connect to multiple IRC networks.

The attached patch modifies rcirc to save the server alias when connecting
to a server so that reconnect will retain the alias.

[-- Attachment #1.2: Type: text/html, Size: 523 bytes --]

[-- Attachment #2: 0001-Save-the-server-alias-on-reconnect.patch --]
[-- Type: text/x-patch, Size: 1297 bytes --]

From 64d286fb94c29cbda684741ae77f11c0734803ab Mon Sep 17 00:00:00 2001
From: Miciah Masters <miciah.masters@gmail.com>
Date: Sun, 10 Dec 2017 20:14:09 -0500
Subject: [PATCH] Save the server alias on reconnect

rcirc does not retain the server alias on reconnect.  As a result, rcirc
fails to re-use server and channel buffers when an alias is used.  Further
problems may ensue when aliases are used to differentiate multiple
connections to the same host, for example when using a single IRC bouncer
or proxy to connect to multiple IRC networks.

Save the server alias when connecting to a server so that reconnect will
retain the alias.
* lisp/net/rcirc.el (rcirc-connect): Include server-alias when setting
  rcirc-connection-info.
---
 lisp/net/rcirc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 3b6b6c8c80..2dd80f49a6 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -585,7 +585,7 @@ rcirc-connect
 
       (setq-local rcirc-connection-info
 		  (list server port nick user-name full-name startup-channels
-			password encryption))
+			password encryption server-alias))
       (setq-local rcirc-process process)
       (setq-local rcirc-server server)
       (setq-local rcirc-server-name
-- 
2.11.0.258.ge05806d

bug#29657: rcirc does not retain the server alias on reconnect

[Noam Postavsky]

tags 29657 fixed
close 29657 26.2
quit

Miciah Dashiel Butler Masters <miciah.masters@gmail.com> writes:

> The attached patch modifies rcirc to save the server alias when connecting
> to a server so that reconnect will retain the alias.

Thanks, pushed to emacs-26.

[1: ef9025f5bc]: 2018-07-10 23:10:53 -0400
  Save the server alias on reconnect (Bug#29657)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ef9025f5bcfb996fbabf5869584e9143bbc81af4