From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32201: 27.0.50; setenv should not change match-data Date: Wed, 18 Jul 2018 21:56:49 -0400 Message-ID: <87o9f46l9a.fsf@gmail.com> References: <87h8kwe4ja.fsf@gmail.com> <87601c88d9.fsf@gmail.com> <87efg0dqg6.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531965307 23235 195.159.176.226 (19 Jul 2018 01:55:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 19 Jul 2018 01:55:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32201@debbugs.gnu.org To: John Shahid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 19 03:55:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffy9m-0005y7-PB for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Jul 2018 03:55:02 +0200 Original-Received: from localhost ([::1]:38957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffyBt-00058Q-HK for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Jul 2018 21:57:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffyBn-00058G-Hw for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 21:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffyBi-0000f3-JA for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 21:57:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42323) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffyBi-0000ey-Dv for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 21:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffyBi-0003Kr-6F for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 21:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jul 2018 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32201-submit@debbugs.gnu.org id=B32201.153196541812812 (code B ref 32201); Thu, 19 Jul 2018 01:57:02 +0000 Original-Received: (at 32201) by debbugs.gnu.org; 19 Jul 2018 01:56:58 +0000 Original-Received: from localhost ([127.0.0.1]:47341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyBe-0003Ka-B7 for submit@debbugs.gnu.org; Wed, 18 Jul 2018 21:56:58 -0400 Original-Received: from mail-io0-f182.google.com ([209.85.223.182]:38557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyBc-0003KM-K1 for 32201@debbugs.gnu.org; Wed, 18 Jul 2018 21:56:57 -0400 Original-Received: by mail-io0-f182.google.com with SMTP id v26-v6so5775303iog.5 for <32201@debbugs.gnu.org>; Wed, 18 Jul 2018 18:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RWwffWtlQloHnkMKgvRHxbZClvklQzeXCSZwW4sY1Bw=; b=HjsLUK6aToHzvGiXkcFDYKfxRxAwm/yQRDnwFfQE2vIICN3PdwnufBiPAXJt7lQVwN NqglFNYGx6RkdaWY2N3wTzZdbSPHPhquuq0R7JNEZg9fmcbPmnW0320D6LKL2gSQM0r6 OYDnW8urWXqAW5oeuwgYi3+EF8hsfGK8Y8t2+sK2Te3WI9GcFOEEq++wil5ngllim80d 8xsh/D/npKW15ZGfE8A/bFE3U1DoYCyYRfgwHCNGqNT8fTe+fH5qbePlI1SSefSmz6f3 ZH7hxKzy5/sNobYrtspwRsXu7UDkpHsycfhUe7WAjxDrXWidLVwlJtXvZ69PqDkSUjrA E/4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RWwffWtlQloHnkMKgvRHxbZClvklQzeXCSZwW4sY1Bw=; b=owwJIkR6fCBApJlWOYyNkKoCvn7WQdR+2MHbS7ZA6cOKlyUHltWdn7vBA0n6mgdfvR sVaBUiHtcfZ/sq6W2eyBfywMFg4i7NAlIL04nzVcFylF74RhxgrjQJnOzI7v95i2KXZy sW8sF6l7LVbRY+jRtoWsIEFuUFMnZjDoXik1boVm+4AxDL9hbQ3iCtLIOGJuCkqWjUmJ GTNQ63dtdJBJp3vWsb03TLQdX3YeB8VnzcjDOYQADGiRBdytkJkEcwRE/jdZZMH7MV7z 69aELrtag0qy+xLSjj+lVESk5KM4JX8gALl/jNnAjaD3bgeQK2p2WYug5pcr5HUz5m+p X0Rw== X-Gm-Message-State: AOUpUlEFAwOo7NRlkVZ0MQ7TvlJUuoTVdR+bdiDBiA4WK2SA4+twbOmJ t87p5Kfo7FSBW6H+Jh17Tlg93g== X-Google-Smtp-Source: AAOMgpfQoS+TJu4jF44411qwL8Arpt1HYYb2ZmyphNTrceubQqTdqavMGDg6dizKp4ssJdm3eGGVow== X-Received: by 2002:a6b:1f8e:: with SMTP id f136-v6mr7083585iof.289.1531965410903; Wed, 18 Jul 2018 18:56:50 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n124-v6sm2122533itg.7.2018.07.18.18.56.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 18:56:50 -0700 (PDT) In-Reply-To: <87efg0dqg6.fsf@gmail.com> (John Shahid's message of "Thu, 19 Jul 2018 00:22:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148654 Archived-At: John Shahid writes: >> Anyway, I don't think setenv should be changed, rather >> abbreviate-file-name should save-match-data around the expand-file-name >> call. After all, today you happened to use setenv in a hook, tomorrow >> someone will use another match-data modifying function. > > I agree, but I also think that there is no reason for `setenv' to use > `string-match' instead of `string-match-p'. It doesn't seem to be using > the match data anyway. I attached the patch that replaces > `string-match' with `string-match-p' in `setenv' and `setenv-internal'. > WDYT ? Seems harmless enough. I'll wait a couple of days, and then push my abbreviate-file-name patch to emacs-26 and this patch to master.