From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: psainty@orcon.net.nz, tzz@lifelogs.com, clement.pit@gmail.com,
michael.albinus@gmx.de, 24150@debbugs.gnu.org, sdl.web@gmail.com
Subject: bug#24150: 26.0.50; New command: dired-create-empty-file
Date: Wed, 01 Aug 2018 14:16:54 +0900 [thread overview]
Message-ID: <87o9emoed5.fsf@calancha-pc.dy.bbexcite.jp> (raw)
In-Reply-To: <83tvofnzq3.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Jul 2018 19:20:52 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>
> No, that's not what I meant. I meant to say that if we call
> dired--find-topmost-parent-dir to update the new entry in the Dired
> buffer, then the doc string of dired-create-empty-file should say that
> it does so. Right now, the doc string says just this:
>
> Create an empty file called FILE.
>
> It says nothing about Dired entries.
>
>> I have added the following comment:
>> +;; We use this function in `dired-create-directory' and
>> +;; `dired-create-empty-file'; the return value is the new entry
>> +;; in the updated Dired buffer.
>
> That's fine. But my comment was about the doc string of
> dired-create-empty-file.
Ahhhh, I see.
Hummmm, I think we assume that Dired will add the new entry;
similarly as `dired-do-delete', which deletes the file and
the entry from the Dired buffer: in the docstring it's not mentioned
that this command drop the entry as well.
It's not mentioned in `dired-create-directory' either.
Every command prefixed with 'dired-' should add/drop buffer entries
automatically as needed.
I think this last sentence belongs to the manual more than the
docstrings (probably already there).
next prev parent reply other threads:[~2018-08-01 5:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 13:25 bug#24150: 25.1.50; New command: dired-create-empty-file Tino Calancha
2016-08-04 13:54 ` Clément Pit--Claudel
2016-08-04 16:29 ` Leo Liu
2016-08-04 17:13 ` Ted Zlatanov
2016-08-04 17:29 ` Drew Adams
2016-08-05 6:03 ` Tino Calancha
2016-08-05 14:48 ` Drew Adams
2016-08-06 12:38 ` Tino Calancha
2016-08-05 6:07 ` Tino Calancha
2017-05-03 8:23 ` Tino Calancha
2017-07-03 4:51 ` bug#24150: 26.0.50; " Tino Calancha
2017-07-03 14:24 ` Eli Zaretskii
2017-07-03 15:04 ` Tino Calancha
2017-07-03 16:33 ` Eli Zaretskii
2017-07-03 20:18 ` Thien-Thi Nguyen
2017-07-07 13:13 ` Ted Zlatanov
2017-07-07 13:17 ` Drew Adams
2017-07-07 13:31 ` Ted Zlatanov
2017-07-03 15:12 ` Drew Adams
2017-07-05 18:28 ` Eli Zaretskii
2017-07-05 19:34 ` Drew Adams
2017-07-07 5:36 ` Tino Calancha
2017-07-07 11:11 ` Drew Adams
2018-07-10 7:01 ` Tino Calancha
2018-07-10 7:42 ` Phil Sainty
2018-07-17 7:39 ` Tino Calancha
2018-07-20 9:03 ` Eli Zaretskii
2018-07-23 3:57 ` Tino Calancha
2018-07-27 8:39 ` Eli Zaretskii
2018-07-31 4:47 ` Tino Calancha
2018-07-31 16:20 ` Eli Zaretskii
2018-08-01 5:16 ` Tino Calancha [this message]
2018-08-01 6:24 ` Eli Zaretskii
2018-08-01 7:13 ` Tino Calancha
2018-08-01 8:56 ` Eli Zaretskii
2018-08-01 9:31 ` Tino Calancha
2018-08-01 11:45 ` Eli Zaretskii
2018-08-02 4:34 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9emoed5.fsf@calancha-pc.dy.bbexcite.jp \
--to=tino.calancha@gmail.com \
--cc=24150@debbugs.gnu.org \
--cc=clement.pit@gmail.com \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=psainty@orcon.net.nz \
--cc=sdl.web@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).