unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Branham <alex.branham@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 33695@debbugs.gnu.org
Subject: bug#33695: 27.0.50; which-function reports wrong imenu information
Date: Wed, 12 Dec 2018 16:53:59 -0600	[thread overview]
Message-ID: <87o99qcq60.fsf@gmail.com> (raw)
In-Reply-To: <5C10C76D.2090702@gmx.at>


On Wed 12 Dec 2018 at 02:31, martin rudalics <rudalics@gmx.at> wrote:

>> Thanks for the reply. This seems to work well, though I haven't tried it
>> in an enormous buffer.
>
> Maybe we should make it optional so people on slower machines have the
> choice.  I have no opinion because I don't use 'which-func-mode' hence
> people who do should chime in.
>
> For me the idea of calculating all function position in a buffer and
> afterwards have 'which-func-mode' scan them to find out which function
> point is in, strikes me as enormous over-kill.  In particular with
> 'syntax-ppss' around which usually should, without any additional
> cost, provide the position where the current functions starts via the
> 9th element of its return value.  But don't let these rantings
> distract you.

That won't help with non-lispy languages like R or python though, I
don't think.

Perhaps we should reverse the order of what which-function checks? It
currently looks at:

1. which-func-functions
2. imenu--index-alist
3. add-log-current-defun

but we could switch those last two. add-log-current-defun should be
faster than reconstructing imenu--index-alist.

Alex





  reply	other threads:[~2018-12-12 22:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 18:58 bug#33695: 27.0.50; which-function reports wrong imenu information Alex Branham
2018-12-11  8:35 ` martin rudalics
2018-12-11 14:32   ` Alex Branham
2018-12-12  8:31     ` martin rudalics
2018-12-12 22:53       ` Alex Branham [this message]
2018-12-13  9:01         ` martin rudalics
2018-12-19 15:42 ` bug#33695: [PATCH] Fix which-function reporting outdated information Alex Branham
2019-01-10 19:55 ` Alex Branham
2019-02-19 21:29   ` Alex Branham
2019-02-22 21:28   ` Alex Branham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o99qcq60.fsf@gmail.com \
    --to=alex.branham@gmail.com \
    --cc=33695@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).