unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Colin Baxter <m43cap@yandex.com>
Cc: Bastien <bzg@gnu.org>, 34983@debbugs.gnu.org, Deus Max <deusmax@gmx.com>
Subject: bug#34983: 27.0.50; Gnus cannot start
Date: Mon, 25 Mar 2019 07:47:21 -0700	[thread overview]
Message-ID: <87o95zhuyu.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <871s2vta45.fsf@yandex.com> (Colin Baxter's message of "Mon, 25 Mar 2019 12:24:42 +0000")

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]


On 03/25/19 12:24 PM, Colin Baxter wrote:
>>>>>> Bastien  <bzg@gnu.org> writes:
>
>     > Hello, Colin Baxter <m43cap@yandex.com> writes:
>
>     >> Warning: Warning - invalid active: "nnrss:AnnPhys" 2059 1 y;
>     >> Warning - invalid active: "nnrss:JMO" 284 1 y; Warning - invalid
>     >> active: "nnrss:PRA" 307 1 y; Warning - invalid active:
>     >> "nnrss:PRL" 852 1 y; Warning - invalid active: "nnrss:ProcRSocA"
>     >> 141 1 y; Warning - invalid active: "nnrss:JPhysA" 133 1 y
>
>     > FWIW, I also had the same kind of warnings with 27.0.50.

This part of the bug, thankfully, is fairly simple, and I think the
attached patch will fix it. Will one or more of you apply this and give
it a shot?



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-active-fix.patch --]
[-- Type: text/x-patch, Size: 1155 bytes --]

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index f1202e176e..8c2411f4d9 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -4029,7 +4029,7 @@ gnus-group-list-active
 		 (insert "       *: "
 			 (gnus-group-decoded-name group)
 			 "\n"))
-       (list 'gnus-group (gethash group gnus-active-hashtb)
+       (list 'gnus-group group
 	     'gnus-unread t
 	     'gnus-level (inline (gnus-group-level group)))))
     (goto-char (point-min))))
diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el
index 82141e0221..5a78df9fe4 100644
--- a/lisp/gnus/gnus-start.el
+++ b/lisp/gnus/gnus-start.el
@@ -2145,9 +2145,12 @@ gnus-active-to-gnus-format
 	(condition-case ()
 	    (if (and (stringp (progn
 				(setq group (read cur)
-				      group (if (numberp group)
-						(number-to-string group)
-					      (symbol-name group)))))
+				      group (cond ((numberp group)
+						   (number-to-string group))
+						  ((symbolp group)
+						   (symbol-name group))
+						  ((stringp group)
+						   group)))))
 		     (numberp (setq max (read cur)))
 		     (numberp (setq min (read cur)))
 		     (null (progn

  reply	other threads:[~2019-03-25 14:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-24 22:09 bug#34983: 27.0.50; Gnus cannot start Bastien
2019-03-24 23:43 ` Eric Abrahamsen
2019-03-25  0:24   ` Deus Max
2019-03-25  0:36     ` Eric Abrahamsen
2019-03-25  5:04       ` Deus Max
2019-03-25  7:09         ` Colin Baxter
2019-03-25 10:54           ` Bastien
2019-03-25 12:24             ` Colin Baxter
2019-03-25 14:47               ` Eric Abrahamsen [this message]
2019-03-25 15:23                 ` Colin Baxter
2019-03-25 17:12                   ` Eric Abrahamsen
2019-06-22 12:48                   ` Lars Ingebrigtsen
2019-06-22 15:54                     ` Eric Abrahamsen
2019-03-25 15:01         ` Eric Abrahamsen
2019-03-25 17:45           ` Deus Max
2019-03-25 17:56             ` Deus Max
2019-03-25  6:36   ` Bastien
2019-03-25 13:07     ` Basil L. Contovounesios
2019-03-25 14:58     ` Eric Abrahamsen
2019-04-02  5:35       ` Bastien
2019-04-02 10:55         ` Basil L. Contovounesios
2019-04-03  0:26           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o95zhuyu.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=34983@debbugs.gnu.org \
    --cc=bzg@gnu.org \
    --cc=deusmax@gmx.com \
    --cc=m43cap@yandex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).