From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling. Date: Mon, 24 Jun 2019 19:58:32 -0400 Message-ID: <87o92msfh3.fsf@gmail.com> References: <86lglj6bkl.fsf@gavenkoa.example.com> <87zhm6silp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111241"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 28434@debbugs.gnu.org, Oleksandr Gavenko To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 01:59:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfYrg-000Sq7-RS for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 01:59:13 +0200 Original-Received: from localhost ([::1]:55594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfYrf-00086U-66 for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 19:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54976) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfYrY-00086G-J3 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 19:59:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfYrX-0006SV-IT for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 19:59:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44843) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfYrX-0006SJ-C4 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 19:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfYrW-0007Fj-IW for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 19:59:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 28434-submit@debbugs.gnu.org id=B28434.156142072427851 (code B ref 28434); Mon, 24 Jun 2019 23:59:02 +0000 Original-Received: (at 28434) by debbugs.gnu.org; 24 Jun 2019 23:58:44 +0000 Original-Received: from localhost ([127.0.0.1]:58387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfYrE-0007F9-KV for submit@debbugs.gnu.org; Mon, 24 Jun 2019 19:58:44 -0400 Original-Received: from mail-io1-f68.google.com ([209.85.166.68]:38752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfYrA-0007Ei-0l; Mon, 24 Jun 2019 19:58:41 -0400 Original-Received: by mail-io1-f68.google.com with SMTP id j6so30845ioa.5; Mon, 24 Jun 2019 16:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9se0D5ZZY51BscKY+HJpnYkmlQ9KFNbpbU8AFZqw0AU=; b=t6ExdE/yAsQoKBdqV4uEXD4gH+6mHTDKKc/Ze9OoIO3/HwmXBND96EaAp0wXo/FhYy +GAooKvOYc5Nck2s/UOK8YaY2JXLF7BDMrtPFr4txCW8/09ttJmeO3+epz1LUmgRssZx eqs33Pl9/hz1pyQx23QsNWDWOVt+DNGS8dw/zrLknMlTsBJHQB6UIpCUSkdV/cY8it6L xXj7sU/FW3L98n2s1mUGQtYvC/a1B7a2/NGUdQpAKdPjPkuTO0PUDbvqowZthPNJtRd8 m7kxQhSTta5UNicsY0BsD5D+thza5/DrVwJhlt2rWBXUoEsd4UJ4LYr33vNfc6VK1wQ6 37mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9se0D5ZZY51BscKY+HJpnYkmlQ9KFNbpbU8AFZqw0AU=; b=oQbnv3SZp7eM2XDSs+kmTEzpHBlS9dlTrUoMtjEI2Ub7vGcsvPT2dtIyGKHHeZfoio ww1RoAxZeWy4BdSWf5mQ+lMHsuBpMiROGyYPeodUZcm8p7kMO/Uq5M3S0rH+BY82EutO r5OgsXM8IfJKly0Gf5l6FPL73Cs/6VA2LcCpYH2c7HGHoOoDMYEVTQwEXOfDREaun0R8 h+mFYwlqOsAJwvA5FZQcbdxVGIZsGVV7uAt941Rw3hOni0whJY6maxXTCGPDV/nMAV3n +Fne1Z6onnFvK6OcC26PcGunYeeKZH8DimE2NetmSbNWuLqulaJlraVHCxJWsrjd79f5 knsg== X-Gm-Message-State: APjAAAUQ4r4YsK2O1+2p2VhQKqDC/p9W4njldH+ZwYUZVWzt3YBFuNBN ku5oCCuMY4djDoy4TTvPyQ4bEAEn X-Google-Smtp-Source: APXvYqy51fwd6e4x/yZGOxgrrw1rbDMsAV7dkq2RNSljF7eSCUIdHLVg1wkF2sIOMvt3fmEBKGSFlw== X-Received: by 2002:a5e:c705:: with SMTP id f5mr16206404iop.113.1561420714107; Mon, 24 Jun 2019 16:58:34 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id v13sm15738654ioq.13.2019.06.24.16.58.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jun 2019 16:58:33 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 25 Jun 2019 01:09:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161314 Archived-At: reopen 28434 tags 28434 - wontfix severity 28434 minor quit Lars Ingebrigtsen writes: > Noam Postavsky writes: > >>> I think if you need this, you should add it to that variable, but I >>> don't think this would be a good default. >> >> Hmm, the "\ No newline at end of file" thing is a de facto standard, so >> shouldn't Emacs recognize it by default? > > Hm... is it? I've always thought that was Emacs telling me I was doing > something wrong. :-) $ diff --version | head -2 diff (GNU diffutils) 3.5 Copyright (C) 2016 Free Software Foundation, Inc. $ diff -u <(echo -n foo) <(echo foo) --- /dev/fd/63 2019-06-24 19:55:40.217569759 -0400 +++ /dev/fd/62 2019-06-24 19:55:40.217569759 -0400 @@ -1 +1 @@ -foo \ No newline at end of file +foo > But if that's the case, then perhaps we should add it? Yeah I think so.