unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Rohan Hart <rohan.hart@fronde.com>
Cc: 27453@debbugs.gnu.org
Subject: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
Date: Tue, 23 Jul 2019 13:31:59 +0200	[thread overview]
Message-ID: <87o91l0yxc.fsf@mouse.gnus.org> (raw)
In-Reply-To: <CAKQntwLqTfeOeJwycQkrMjXQY4E5UA2QcBbrtjDkREXeEBr+xw@mail.gmail.com> (Rohan Hart's message of "Tue, 23 Jul 2019 08:42:40 +1200")

Rohan Hart <rohan.hart@fronde.com> writes:

> Well sure, I only raised this as log-view states:
>
> ;; Currently supports the format output by:
> ;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.
>
> And later mentions code related to both darcsum and vc-darcs.

Then perhaps it does make sense to add the regexp to log-view-message-re
after all.  The current definition is:

(defvar log-view-message-re
  (concat "^\\(?:revision \\(?1:[.0-9]+\\)\\(?:\t.*\\)?" ; RCS and CVS.
          "\\|r\\(?1:[0-9]+\\) | .* | .*"                ; Subversion.
          "\\|D \\(?1:[.0-9]+\\) .*"                     ; SCCS.
          ;; Darcs doesn't have revision names.  VC-darcs uses patch names
          ;; instead.  Darcs patch names are hashcodes, which do not appear
          ;; in the log output :-(, but darcs accepts any prefix of the log
          ;; message as a patch name, so we match the first line of the log
          ;; message.
          ;; First loosely match the date format.
          (concat "\\|[^ \n].*[^0-9\n][0-9][0-9]:[0-9][0-9][^0-9\n].*[^ \n]"
                  ;;Email of user and finally Msg, used as revision name.
                  "  .*@.*\n\\(?:  \\* \\(?1:.*\\)\\)?")
          "\\)$")

Is VC-darcs something else than darcs?  Or is that an Emacs package?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-07-23 11:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23  0:49 bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format Rohan Hart
2019-07-21 17:40 ` Lars Ingebrigtsen
2019-07-21 20:36   ` Rohan Hart
2019-07-22 12:28     ` Lars Ingebrigtsen
2019-07-22 20:42       ` Rohan Hart
2019-07-23 11:31         ` Lars Ingebrigtsen [this message]
2019-07-23 20:57           ` Rohan Hart
2019-07-24 12:32             ` Lars Ingebrigtsen
2020-08-20 16:01               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o91l0yxc.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=27453@debbugs.gnu.org \
    --cc=rohan.hart@fronde.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).