* bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings
@ 2019-08-14 0:38 Alex Branham
2019-08-14 19:55 ` Eric Abrahamsen
0 siblings, 1 reply; 4+ messages in thread
From: Alex Branham @ 2019-08-14 0:38 UTC (permalink / raw)
To: 37022
Hi -
The commands gnus-1 and gnus have identical docstrings. gnus-1 should
probably specify how it differs from just M-x gnus (or be
noninterative).
Thanks,
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings
2019-08-14 0:38 bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings Alex Branham
@ 2019-08-14 19:55 ` Eric Abrahamsen
2019-08-23 15:55 ` Alex Branham
0 siblings, 1 reply; 4+ messages in thread
From: Eric Abrahamsen @ 2019-08-14 19:55 UTC (permalink / raw)
To: Alex Branham; +Cc: 37022
Alex Branham <alex.branham@gmail.com> writes:
> Hi -
>
> The commands gnus-1 and gnus have identical docstrings. gnus-1 should
> probably specify how it differs from just M-x gnus (or be
> noninterative).
I'm inclined to think that gnus-1 (and gnus-no-server-1) shouldn't be
interactive. I can't see any point to it -- the *-1 variants live in
gnus-start.el and are not autoloaded. It seems like Gnus' entry points
should be interactive and autoloaded, and what happens after that is
internals.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings
2019-08-14 19:55 ` Eric Abrahamsen
@ 2019-08-23 15:55 ` Alex Branham
2019-08-25 6:06 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Alex Branham @ 2019-08-23 15:55 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 37022, Alex Branham
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
tags 37022 + patch
quit
On Wed 14 Aug 2019 at 12:55, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
> Alex Branham <alex.branham@gmail.com> writes:
>
>> Hi -
>>
>> The commands gnus-1 and gnus have identical docstrings. gnus-1 should
>> probably specify how it differs from just M-x gnus (or be
>> noninterative).
>
> I'm inclined to think that gnus-1 (and gnus-no-server-1) shouldn't be
> interactive. I can't see any point to it -- the *-1 variants live in
> gnus-start.el and are not autoloaded. It seems like Gnus' entry points
> should be interactive and autoloaded, and what happens after that is
> internals.
Here's a patch that makes them noninteractive.
Alex
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-gnus-gnus-start.el-gnus-1-gnus-no-server-1-Make.patch --]
[-- Type: text/x-patch, Size: 1198 bytes --]
From 2c2411d94618d8c719c2583fe7ed1c19d02cbae9 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 23 Aug 2019 10:51:48 -0500
Subject: [PATCH] * lisp/gnus/gnus-start.el (gnus-1, gnus-no-server-1): Make
noninteractive
bug#37022
---
lisp/gnus/gnus-start.el | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el
index 930d522c41..e8775c6667 100644
--- a/lisp/gnus/gnus-start.el
+++ b/lisp/gnus/gnus-start.el
@@ -738,7 +738,6 @@ gnus-no-server-1
and not a positive number, Gnus will prompt the user for the name
of an NNTP server to use. As opposed to \\[gnus], this command
will not connect to the local server."
- (interactive "P")
(let ((val (or arg (1- gnus-level-default-subscribed))))
(gnus val t slave)
(make-local-variable 'gnus-group-use-permanent-levels)
@@ -749,8 +748,6 @@ gnus-1
If ARG is non-nil and a positive number, Gnus will use that as the
startup level. If ARG is non-nil and not a positive number, Gnus will
prompt the user for the name of an NNTP server to use."
- (interactive "P")
-
(if (gnus-alive-p)
(progn
(gnus-run-hooks 'gnus-before-resume-hook)
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings
2019-08-23 15:55 ` Alex Branham
@ 2019-08-25 6:06 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-08-25 6:06 UTC (permalink / raw)
To: Alex Branham; +Cc: Eric Abrahamsen, 37022
Alex Branham <alex.branham@gmail.com> writes:
> Here's a patch that makes them noninteractive.
Thanks; applied to the trunk.
I don't know why those functions were ever interactive.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-25 6:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-14 0:38 bug#37022: 27.0.50; gnus-1 and gnus have identical docstrings Alex Branham
2019-08-14 19:55 ` Eric Abrahamsen
2019-08-23 15:55 ` Alex Branham
2019-08-25 6:06 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).