unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dima Kogan <dima@secretsauce.net>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 36056@debbugs.gnu.org
Subject: bug#36056: Regression? (Python Documentation String Indent In Auto Fill Mode)
Date: Mon, 09 Sep 2019 15:02:37 -0700	[thread overview]
Message-ID: <87o8zt2kn6.fsf@shorty.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87zhjealrj.fsf_-_@gmail.com>

Noam Postavsky <npostavs@gmail.com> writes:

> The problem seems to be that fill-newline puts the space on the new
> line when breaking the line, and python-indent-line (which is called
> when fill-indent-according-to-mode is t) leaves indentation inside
> strings as-is.
>
> Maybe the solution is to bind fill-indent-according-to-mode only during
> auto-filling?  The patch below seems to work for both this bug's OP, and
> your case.

Thanks for looking at this. I haven't tried your proposed patch, but it
certainly looks like it would work. Do you think it's a reasonable
solution? Feels a bit like a workaround, but we have comments and tests,
so maybe it's fine, I guess.

Thanks again.





  reply	other threads:[~2019-09-09 22:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02  9:01 bug#36056: 26.2; Python Documentation String Indent In Auto Fill Mode ricercar
2019-06-03  0:57 ` Basil L. Contovounesios
2019-06-22 23:31   ` Noam Postavsky
2019-09-07 21:26 ` bug#36056: Regression? Dima Kogan
2019-09-08 14:46   ` bug#36056: Regression? (Python Documentation String Indent In Auto Fill Mode) Noam Postavsky
2019-09-09 22:02     ` Dima Kogan [this message]
2019-09-13  1:49       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8zt2kn6.fsf@shorty.i-did-not-set--mail-host-address--so-tickle-me \
    --to=dima@secretsauce.net \
    --cc=36056@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).