From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#37321: 27.0.50; Excessive gc in a use case (el-search) Date: Wed, 09 Oct 2019 16:47:58 +0200 Message-ID: <87o8yqynz5.fsf@web.de> References: <87lfv1pm5x.fsf@web.de> <874l1mc01w.fsf@web.de> <87woeidd4g.fsf@web.de> <733d0142-51ee-55df-de0c-cca7c989b370@cs.ucla.edu> <875zlgu2y8.fsf@web.de> <6d670180-e2ee-030f-ef0e-ad0c5c7a8ef5@cs.ucla.edu> <87tv8zs2r9.fsf@web.de> <83tv8zl0es.fsf@gnu.org> <87sgo3typ1.fsf@web.de> <83o8yry56c.fsf@gnu.org> <87lftvzjmr.fsf@web.de> <83k19fy4p7.fsf@gnu.org> <87pnj7xzhe.fsf@web.de> <83d0f7xwr8.fsf@gnu.org> <8736g3pg2m.fsf@web.de> <83a7abxubl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203494"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: eggert@cs.ucla.edu, 37321@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 21:01:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIHDJ-000qng-6r for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 21:01:33 +0200 Original-Received: from localhost ([::1]:54440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIHDH-0001FW-1q for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 15:01:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35068) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIDGy-0003i9-Dw for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 10:49:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIDGx-0006iG-DV for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 10:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIDGw-0006iA-Vl for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 10:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIDGw-0003A8-TZ for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37321 X-GNU-PR-Package: emacs Original-Received: via spool by 37321-submit@debbugs.gnu.org id=B37321.157063250212106 (code B ref 37321); Wed, 09 Oct 2019 14:49:02 +0000 Original-Received: (at 37321) by debbugs.gnu.org; 9 Oct 2019 14:48:22 +0000 Original-Received: from localhost ([127.0.0.1]:53834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIDGI-00039B-Cf for submit@debbugs.gnu.org; Wed, 09 Oct 2019 10:48:22 -0400 Original-Received: from mout.web.de ([212.227.15.14]:49581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIDGF-00038v-Jw for 37321@debbugs.gnu.org; Wed, 09 Oct 2019 10:48:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1570632476; bh=jMNbfVp7autsUnNmCyrgCcMRJzag87jIfwXL0MUo7eQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=c0vCgcDu8znyUMti9F+FFsfUz7Zedy98EKQec3CGmtjN8A6LP1ZsVDD0k3Exy3Omf 7ss+5zhURptDe2/W+Fien/5c0VmLF2wcPdxBD8wQnoieRs4gM0PrSSrXKMDZrsR5Pv ahXm2xk3cj9Su7Kga1HfKSYdxx0SW5SkAUR+TI6s= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([92.208.91.33]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0La1Sn-1ho52X0Pwz-00lkwr; Wed, 09 Oct 2019 16:47:56 +0200 In-Reply-To: <83a7abxubl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Oct 2019 16:03:58 +0300") X-Provags-ID: V03:K1:TlRoKrHdeFx/JvCn2Fr6jKMTNLzPbC5T235Y8HcANTzwFkVIsUp 6igG6dBd95oyZMwlzgefo0KynR3cEix1pi8K+wLOqhqDM5JdQ58sTUuzhK7IoHrlwAF1Dpr eg2R7cwK/TyOE5ziO+6xMmJvUJU8f3VaKxHZxQg2/Qbpa+temwFtTlVn+nJhRHKYooa14ZE VXwaLXTnw80O/O5AIHS0g== X-UI-Out-Filterresults: notjunk:1;V03:K0:sM7562Gqp28=:Cf4xdqDBKFSt3vNZo0JUxj ytj72P4Gjr5PYjnZrIGN1/Vb/HgeExS4D+JRRKVKPjVmuGO+mDLurAcQbVyM6Uvd0wlEZeQuo m4m6ZDuG4ZiJPHNeDldVm1b15lswmJDa7SlMqWt/CYwgG+GMM4TK7Rg7g78VxgC9r+tx9nZbv cF419LDBG18Oh/xGSB40LtBcXj6NcdLQ6MtE0++tIoUON1t3EefcvawRU3vj8iC/kIRAmt2Fo S8bWwAlSMoAz8bhgpHOr69Y+spJT8zJaziojSmLEd/yBffIvdn7w0rNMLlv2SK4BQjXpClL2X Qz0UWJMdtvX9BQ740+L1TFEdwqmfwS+kPfUczdlpaSZDgSabEyd+4Bzkb3Jrx1jU3HiFxrXI8 5+qmy2VECPi8kYhCJ+TMGPFNhb2d63/+qLeuegUFLUDBcThwbib9MwuaHUWU96YGAc78rMG7u 2sTEdH25YULtLl2WOxqbLNsChQe/qdbSZOPQ7nC+wQgpeLFQ09HyW0GnsLe6jby/zwpsbsYuj Um1ZhjYjTVT7p8cTJTWz7i/sxejJvkgoi9ttODVZ3y2lEeNkF61fEtyYNALOmesMyyV3t+9iL QTP//uhVrSeXEQ0YsFB2wIuZRomtJYv0RXwcmhGS8P504/NMu2VOjLearD6WBd02ZQeoFwfsZ 9INsBAop6sG7E75qgXwa5wduzJA7r75IEWVpHQhplCCpSZXlRD7koeEMOzxrwPJLMTxR2hkHg uNZXgdwzAkrGJiZB0b75aIv1/X5K5guwr8vCeaOpNyrumi8A9hflVYXuyttLccpxAj1qiqMw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168745 Archived-At: Eli Zaretskii writes: > > in a way that gc doesn't lower the speed that much > > AFAIK, the latter can only be done by changing your algorithms to > produce less garbage. I tried to find out what code produces the most garbage. It turned out that ca. 50% of garbage was generated by code that prevents infinite recursion when recursing into nested structures. I use hash tables to collect visited objects, and the hash tables cause the garbage. I tried to reuse hash tables and clear them after each use, but this makes the code much slower than what I win from gc. But 99,9% of el-searched code isn't cyclic, so the effort is for nothing most of the time. Is there an efficient way to find out if a given object is cyclic? For now I try with this: (lambda () (save-excursion) (goto-char (point-min)) (search-forward-regexp "#[0-9+]=[^\"]" nil t)) (all treated objects are read from a buffer, so I can inspect the contents) and get good results but it feels a bit hackish. Thanks, Michael.