From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 22:46:55 +0300 Organization: LINKOV.NET Message-ID: <87o8yg5v80.fsf@mail.linkov.net> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <83y2xkcyu9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="220951"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: andreyorst@gmail.com, spacibba@aol.com, 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 21:56:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKpOz-000vC2-Br for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 21:56:09 +0200 Original-Received: from localhost ([::1]:47632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKpOy-00032b-5g for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 15:56:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36940) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKpNw-0002BT-3z for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:55:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKpNu-0004Dg-Q0 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:55:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37771) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKpNu-0004DV-MS for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKpNu-0001Ok-JF for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712556545295 (code B ref 37774); Wed, 16 Oct 2019 19:55:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 19:54:14 +0000 Original-Received: from localhost ([127.0.0.1]:46589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpN8-0001NL-9D for submit@debbugs.gnu.org; Wed, 16 Oct 2019 15:54:14 -0400 Original-Received: from anteater.elm.relay.mailchannels.net ([23.83.212.3]:59810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpN6-0001NC-8o for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 15:54:13 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 142561432F2; Wed, 16 Oct 2019 19:54:11 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a63.g.dreamhost.com (100-96-92-142.trex.outbound.svc.cluster.local [100.96.92.142]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8D24E143310; Wed, 16 Oct 2019 19:54:10 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a63.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 16 Oct 2019 19:54:10 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wiry-Harmony: 0b8c5aa611fa78be_1571255650819_2371294413 X-MC-Loop-Signature: 1571255650819:202955918 X-MC-Ingress-Time: 1571255650819 Original-Received: from pdx1-sub0-mail-a63.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a63.g.dreamhost.com (Postfix) with ESMTP id 7A63D819A7; Wed, 16 Oct 2019 12:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Yc9MYX5k/f1hALsTK63W+pGLPVQ=; b= JSiaGWr3+dbVkBxTVLCcyUUkE8jhYp2LkfTBwpKBEsMDm6S9Cp4J3AMXHKGv+CBr 371vuuH3f8fiusAa+QzYSzNHMcfNPozJ4W/Juhmw04kv25A+IaS+x4W0mqE76Htj TxNby4ikxk5Nk7tkjCDuDyfmlkXQnEjrEvFArsSo2mY= Original-Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a63.g.dreamhost.com (Postfix) with ESMTPSA id 34BAB819B6; Wed, 16 Oct 2019 12:54:00 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a63 In-Reply-To: <83y2xkcyu9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 16 Oct 2019 21:46:54 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169487 Archived-At: >> 1. Backward-compatibility problem: >> >> I had to spend significant time investigating why the region face broke >> recently, and discovered that customized faces in custom-set-faces need >> to be updated. > > I'm not sure I understand: the region face is defined to be extended > beyond EOL. How does custom-set-faces enter this picture, and why did > you need to do anything about the customized faces? The region face customized long ago in the init file has no ':extend t' face attribute, e.g. (custom-set-faces '(region ((((class color) (background light)) (:background "gray90")))) >> Soon I tired fixing their customizations one by one manually, > > Which other faces needed to be "fixed", how, and why? All diff faces and faces that have a distinct background color like 'comint-highlight-input' (should extend to window edge to help locating visually the command line in shell buffers), 'org-block' (because it highlights code blocks), 'xref-file-header' for the same reason as diff faces, i.e. faces that highlights blocks. > Why are you talking only about the colors? face extension is not only > about colors, it's about other attributes as well: underline, > strike-through, box, etc. You list underline with foreground color, > but they are not the same as color, especially not when face extension > is concerned. They actually behave more like background colors. Yes, this new feature is useful for all these face attributes to extend them to EOL. The only exception is background colors. All complaints are only about extending background colors to EOL. So the change could apply to all face attributes except background colors. Only other attributes should be extended to EOL, because when such face attributes like underline and strike-through are displayed over an empty space beyond EOL, this looks ugly. > And then there are faces with both foreground and background colors. Actually the distinction is not so simple: even some background colors need to extend to EOL, such as when used in combination with the 'box' face attributes, because when a button takes two lines, extending the button box face to the window edge looks ugly. >> As I see the change was meant to fix only the problem that relates to >> faces with distinct foreground, because indeed underlines extended >> to the window edge look very ugly. So the change should affect >> only faces with distinct foreground. > > That wasn't the intent. the intent was explicitly to cause the change > in background color and underline/strikethough/etc. attributes--those > which show in the face extension. Foreground color doesn't show in > face extension. > >> This screenshot demonstrates how badly broken these blocks are now >> in diff-mode that it makes harder to read diffs: > > I'm sorry, but I don't see why it is broken or hard to read. Because there is no distinctive rectangular header anymore, and no diff hunk blocks. >> Ideally to be more nice-looking, background colors in such faces should be >> extended to the column defined e.g. by display-fill-column-indicator-column. > > That would be ugly if the line's text extends beyond the fill-column, > no? Also, it would look even uglier with variable-pitch fonts. Extending to the fill-column could be an optional feature. It won't work with variable-pitch fonts the same way as filling to fill-column doesn't work with variable-pitch fonts. But if some line's text will extend beyond the fill-column with fixed-pitch fonts, this even could help to find long lines (like in whitespace-mode).