From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#12436: 24.2.50; rename `(next|previous)-multiframe-window' Date: Sat, 02 Nov 2019 02:37:22 +0100 Message-ID: <87o8xvrrcd.fsf@marxist.se> References: <41448D3E81B245CAA20C88FD41B31D26@us.oracle.com> <87fuu57img.fsf@gnus.org> <878sp1x3vm.fsf@joffe.skangas.se> <83pnidnh6t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="69410"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: larsi@gnus.org, 12436@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 02 02:38:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQiMs-000HxT-IG for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Nov 2019 02:38:18 +0100 Original-Received: from localhost ([::1]:44424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQiMq-0005hY-OE for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 21:38:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53988) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQiMd-0005g3-Sf for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 21:38:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQiMc-0000ft-1t for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 21:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48935) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQiMb-0000ff-Q2 for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 21:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQiMb-0007rT-Ke for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 21:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Nov 2019 01:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12436 X-GNU-PR-Package: emacs Original-Received: via spool by 12436-submit@debbugs.gnu.org id=B12436.157265865330176 (code B ref 12436); Sat, 02 Nov 2019 01:38:01 +0000 Original-Received: (at 12436) by debbugs.gnu.org; 2 Nov 2019 01:37:33 +0000 Original-Received: from localhost ([127.0.0.1]:57756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQiM9-0007qe-6l for submit@debbugs.gnu.org; Fri, 01 Nov 2019 21:37:33 -0400 Original-Received: from host.gofardesign.uk ([208.79.239.190]:52548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQiM7-0007qQ-Ad for 12436@debbugs.gnu.org; Fri, 01 Nov 2019 21:37:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fWKcKzsKm8Cy5rhYkcYRexFYxJkqOzK+dcCeO7AJUKQ=; b=bVBUhcRdGV/qZjVmAYaZ6iANGM 9SV8jVIuxmvY7kddDkws6ZDogYggOCPXawhqL8AF3tqD95F2s49SwgWbu2NTdo4g7klCnx8F++t6N tsUkOt0qsfDs3MgplbGUn3N71GcRxk9zjegaXNq3oIg37SyL2Bj00MtH06vOnB7rniuw=; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:51662 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iQiM0-0004nU-RD; Fri, 01 Nov 2019 20:37:25 -0500 In-Reply-To: <83pnidnh6t.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 31 Oct 2019 16:05:46 +0200") X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170739 --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Makes sense to me. Any objections to the below patch? > > I don't object, although I do wonder what could be the point of > renaming commands which were known under these names for the last > 28(!) years. Given their age, perhaps consider not obsoleting the old > names: who knows whether someone out there has these names burned into > their muscle memory? Makes sense to me; I've attached an updated patch here. If there are no objections, I intend to push it within a couple of days. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Rename-multiframe-window-to-window-any-frame.patch >From b13ea22c9338097560d499872ef0a1f4aea15ba7 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Wed, 30 Oct 2019 23:27:37 +0100 Subject: [PATCH] Rename `*-multiframe-window' to '*-window-any-frame' Suggested by Drew Adams. * lisp/frame.el (next-multiframe-window): Define as obsolete alias for... (next-window-any-frame): ...new function name. (previous-multiframe-window): Define as obsolete alias for... (previous-window-any-frame): ...new function name. (Bug#12436) * lisp/term/ns-win.el (global-map): Use new command name. * doc/emacs/windows.texi (Other Window): Document it. * etc/NEWS: Announce it. --- doc/emacs/windows.texi | 4 ++-- etc/NEWS | 10 ++++++++++ lisp/frame.el | 7 +++++-- lisp/term/ns-win.el | 2 +- 4 files changed, 18 insertions(+), 5 deletions(-) diff --git a/doc/emacs/windows.texi b/doc/emacs/windows.texi index 19f6cff7bf..53e9a4bb58 100644 --- a/doc/emacs/windows.texi +++ b/doc/emacs/windows.texi @@ -181,12 +181,12 @@ Other Window back and finish supplying the minibuffer argument that is requested. @xref{Minibuffer Edit}. -@findex next-multiframe-window +@findex next-window-any-frame The @code{other-window} command will normally only switch to the next window in the current frame (unless otherwise configured). If you work in a multi-frame environment and you want windows in all frames to be part of the cycle, you can rebind @kbd{C-x o} to the -@code{next-multiframe-window} command. (@xref{Rebinding}, for how to +@code{next-window-any-frame} command. (@xref{Rebinding}, for how to rebind a command.) @kindex C-M-v diff --git a/etc/NEWS b/etc/NEWS index e614197125..e005cc9406 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -202,6 +202,16 @@ the new version of the file again.) * Changes in Emacs 27.1 ++++ +** 'next/previous-multiframe-window' have been renamed. +The new names are as follows: + + 'next-multiframe-window' -> 'next-window-any-frame' + 'previous-multiframe-window' -> 'previous-window-any-frame' + +The old names are maintained as function aliases for backward +compatibility. + ** emacsclient +++ diff --git a/lisp/frame.el b/lisp/frame.el index 92fe57fbe6..1a15a4c9f2 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -673,7 +673,7 @@ get-other-frame is not considered (see `next-frame')." (if (equal (next-frame) (selected-frame)) (make-frame) (next-frame))) -(defun next-multiframe-window () +(defun next-window-any-frame () "Select the next window, regardless of which frame it is on." (interactive) (select-window (next-window (selected-window) @@ -681,7 +681,7 @@ next-multiframe-window 0)) (select-frame-set-input-focus (selected-frame))) -(defun previous-multiframe-window () +(defun previous-window-any-frame () "Select the previous window, regardless of which frame it is on." (interactive) (select-window (previous-window (selected-window) @@ -689,6 +689,9 @@ previous-multiframe-window 0)) (select-frame-set-input-focus (selected-frame))) +(defalias 'next-multiframe-window 'next-window-any-frame) +(defalias 'previous-multiframe-window 'previous-window-any-frame) + (defun window-system-for-display (display) "Return the window system for DISPLAY. Return nil if we don't know how to interpret DISPLAY." diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el index 83b845b1a5..1841e679ac 100644 --- a/lisp/term/ns-win.el +++ b/lisp/term/ns-win.el @@ -102,7 +102,7 @@ 'ns-alternatives-map ;; Here are some Nextstep-like bindings for command key sequences. (define-key global-map [?\s-,] 'customize) -(define-key global-map [?\s-'] 'next-multiframe-window) +(define-key global-map [?\s-'] 'next-window-any-frame) (define-key global-map [?\s-`] 'other-frame) (define-key global-map [?\s-~] 'ns-prev-frame) (define-key global-map [?\s--] 'center-line) -- 2.20.1 --=-=-=--