bug#39385: Erroneous interaction of eval-when-compile and condition-case

[Noam Postavsky <npostavs@gmail.com>]

Alan Mackenzie <acm@muc.de> writes:
>
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> (defmacro c-safe (&rest body)
>   ;; safely execute BODY, return nil if an error occurred
>   `(condition-case nil
>        (progn ,@body)
>      (error nil)))
>
> (defmacro foo ()
>   (error "This message should not be seen"))
>
> (eval-when-compile
>   (c-safe (foo)))
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>
> Now do M-x byte-compile-file <CR> bad-eval-when-compile.el <CR>.  This
> erroneously throws the error:
>
>     This message should not be seen

The same happens without eval-when-compile.

> .  This should have been caught by the condition-case generated by
> (c-safe ...).

I don't think so, because the condition-case is in the code generated by
c-safe (because the condition-case is quoted), whereas the error is
signaled while generating the code (because the error call is not
quoted).