From: Juri Linkov <juri@linkov.net>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: spacibba@aol.com, npostavs@gmail.com, 39512@debbugs.gnu.org,
contovob@tcd.ie
Subject: bug#39512: 28.0.50; Add command isearch-yank-region
Date: Mon, 10 Feb 2020 02:45:17 +0200 [thread overview]
Message-ID: <87o8u75lfe.fsf@mail.linkov.net> (raw)
In-Reply-To: <87eev52bw6.fsf@calancha-pc.dy.bbexcite.jp>
> I have added global keybinding `M-s M-.' for my `isearch-yank-region'.
Thanks.
> `isearch-yank-kill' and `isearch-yank-region' are good names for the
> use case of calling them once we are in an interactive search.
>
> The names are not any good for the use case of calling them directly
> (from a global keybinding). We might want:
>
> 1. aliases `isearch-forward-kill', `isearch-forward-region'
Aliases might add more confusion and make impression that
these are separate commands when displayed in a list of isearch commands,
e.g. in completion list, in documentation.
> 2. restrict the use of them for just inside the interactive search, and
> define the new commands (`isearch-forward-kill',`isearch-forward-region')
> as those calling `isearch-mode' at the beginning.
Restricting would be worse.
So maybe `isearch-yank-kill' and `isearch-yank-region' still are
not too bad names to use as entry points to enable isearch mode.
> + (define-key map "\M-." 'isearch-yank-region)
Some doubts are about `M-.' - what if some users might want to use `M-.'
to exit isearch and run its global binding `xref-find-definitions'
on the found symbol? Maybe better to bind `isearch-yank-region'
to `M-s M-.' in isearch-mode too?
> I have some advice in that function that lets me call it with no arguments.
Maybe a new function could be added as a wrapper around
`(funcall region-extract-function)' and with its argument optional.
next prev parent reply other threads:[~2020-02-10 0:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 18:04 bug#39512: 28.0.50; Add command isearch-yank-region Tino Calancha
2020-02-08 23:47 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-02-09 0:31 ` Juri Linkov
2020-02-09 11:21 ` Tino Calancha
2020-02-09 12:38 ` Tino Calancha
2020-02-10 0:45 ` Juri Linkov [this message]
2020-02-12 22:10 ` Juri Linkov
2020-08-09 11:28 ` Lars Ingebrigtsen
2020-08-09 23:23 ` Juri Linkov
2020-08-10 1:19 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-10 23:49 ` Juri Linkov
2020-08-11 1:12 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-11 23:13 ` Juri Linkov
2020-08-12 17:41 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-12 23:44 ` Juri Linkov
2020-08-13 3:14 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-15 20:52 ` Juri Linkov
2021-04-18 15:34 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-20 20:29 ` Juri Linkov
2021-04-21 20:41 ` Juri Linkov
2020-08-10 17:00 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8u75lfe.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=39512@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=npostavs@gmail.com \
--cc=spacibba@aol.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).