From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#2160: 23.0.60; Indentation of LOOP (cl-indent.el) Date: Sat, 29 Feb 2020 03:30:40 +0100 Message-ID: <87o8ti86r3.fsf@stefankangas.se> References: <87ab956pyk.fsf@freebits.de> <87pnjifc4o.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="42826"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: tcr@freebits.de, 2160@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 29 03:31:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7ruJ-000B2O-Sr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Feb 2020 03:31:12 +0100 Original-Received: from localhost ([::1]:56372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7ruI-0004uG-VF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Feb 2020 21:31:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41976) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7ruB-0004u6-Cn for bug-gnu-emacs@gnu.org; Fri, 28 Feb 2020 21:31:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7ruA-0003fi-CU for bug-gnu-emacs@gnu.org; Fri, 28 Feb 2020 21:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7ruA-0003fb-5i for bug-gnu-emacs@gnu.org; Fri, 28 Feb 2020 21:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7ruA-0008Kg-1u for bug-gnu-emacs@gnu.org; Fri, 28 Feb 2020 21:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Feb 2020 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2160 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 2160-submit@debbugs.gnu.org id=B2160.158294345832018 (code B ref 2160); Sat, 29 Feb 2020 02:31:01 +0000 Original-Received: (at 2160) by debbugs.gnu.org; 29 Feb 2020 02:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:34013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7ru5-0008KL-Tm for submit@debbugs.gnu.org; Fri, 28 Feb 2020 21:30:58 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:52264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7ru1-0008K1-SV for 2160@debbugs.gnu.org; Fri, 28 Feb 2020 21:30:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Cw5ukQ18afSn9KK7lpy6EfcSWHq9afBCqM4JPfc+68U=; b=kdnN/xU+LmtzhwMHCBWZq+TuYG FEf7CjFk3GRGMogPk58Kb+SYWNWIv2Bd8Immfb8gTI0N4ZgXvY6ZjZBs9sZXxd3vJHCI9WuRglbg0 RS5M9D8uha3VCDxrB08ziK0WVlVPcViwWTVmmoiokvnxvRBEiDLIR/yQSA/HggX3uFLnSk9fZATMc 9wl4FXr8wu3T63X7YMcxZa0ZTGIC7WKIHNfQENgOoWjaIgBo8Fk07h4HLbVIxDb99tq2aMVglL6VN 9OsOfsLbQOYUOEBUgAcmp0gMU2ZYWkKhfG5XkiZXPbBeSA/J9GOIZ54FEvosxlfcDE+uzN0m7qUbQ s8cZSc4Q==; Original-Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:47308 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1j7rtr-001KvQ-6e; Fri, 28 Feb 2020 21:30:43 -0500 In-Reply-To: <87pnjifc4o.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 30 Sep 2019 09:59:19 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176632 Archived-At: Lars Ingebrigtsen writes: > tcr@freebits.de writes: > >> When using `common-lisp-indent-function', LOOP forms are by default >> indented as follows >> >> (loop for x in '(a b c) >> for y in '(1 2 3) >> collect (cons x y)) > > (I'm going through old bug reports that unfortunately didn't get any > response at the time.) > > This is still the case in Emacs 27. > >> Setting the following >> >> (setq lisp-simple-loop-indentation 1 >> lisp-loop-keyword-indentation 6 >> lisp-loop-forms-indentation 6) >> >> makes it be indented like >> >> (loop for x in '(a b c) >> for y in '(1 2 3) >> collect (cons x y)) >> >> which I think is more readable, and more canonical. >> >> I hence propose to change the default values in cl-indent.el of the >> above variables accordingly. > > I agree that changing the default here would be a good idea, because > that's a very non-standard Common Lisp indentation. Does anybody object > to changing it? No further comments within 21 weeks, so I'll just chime in to say the suggestion makes sense to me. It seems to be the usual indentation in the Common Lisp world, and I see no reason to do things differently. It certainly makes the code more readable. People have had ample time to protest, so perhaps we should just go ahead and make the change on the master branch. Best regards, Stefan Kangas