From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#40335: 27.0.90; elp-not-profilable not up to date Date: Mon, 13 Apr 2020 18:55:09 +0200 Message-ID: <87o8rv9vgy.fsf@gmail.com> References: <87wo6ja15q.fsf@gmail.com> <85sgh7zar6.fsf@gmail.com> <87sgh79zbm.fsf@gmail.com> <85pncbz80d.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102404"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40335@debbugs.gnu.org, Philipp Stephani To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 13 18:55:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jO2Mj-000Q1m-4n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Apr 2020 18:55:21 +0200 Original-Received: from localhost ([::1]:46622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO2Mi-0000f3-60 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Apr 2020 12:55:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37698) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO2MQ-0000eJ-Oh for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2020 12:55:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jO2MP-0007lF-Q0 for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2020 12:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49100) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jO2MP-0007l3-MQ for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2020 12:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jO2MP-0003oY-M3 for bug-gnu-emacs@gnu.org; Mon, 13 Apr 2020 12:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Apr 2020 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40335 X-GNU-PR-Package: emacs Original-Received: via spool by 40335-submit@debbugs.gnu.org id=B40335.158679688214635 (code B ref 40335); Mon, 13 Apr 2020 16:55:01 +0000 Original-Received: (at 40335) by debbugs.gnu.org; 13 Apr 2020 16:54:42 +0000 Original-Received: from localhost ([127.0.0.1]:60646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jO2M6-0003nz-CN for submit@debbugs.gnu.org; Mon, 13 Apr 2020 12:54:42 -0400 Original-Received: from mail-lf1-f66.google.com ([209.85.167.66]:43498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jO2M4-0003nl-IK for 40335@debbugs.gnu.org; Mon, 13 Apr 2020 12:54:41 -0400 Original-Received: by mail-lf1-f66.google.com with SMTP id k28so7051271lfe.10 for <40335@debbugs.gnu.org>; Mon, 13 Apr 2020 09:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=e2phenAZxeF2KbNSOo1NERscTLD4PWbM1r8NWK9H0Mc=; b=kzEjPuU7qB/dFIRpNKFZORHixrXC1d+6i5xSdBjpCwP8W0rSMNrdyfZ9LyevDAAeSu ZCZJF8JK1spf6gACdrpEsWVYOq+N880FhcF7szrxfHcqdSjs6X3wruIU8u6p/bnoO55A q/ujWrtFyxm6sWpGVAPIhTDKFPgh3nxO2Nk/G0pN7RA75H893KZUVhiLZu+rjUZNDXUg /wHNTIpmAeiPyC/uzBcfcuDoJlG4/XZOP5smktEULNts5Uc/sqWi78eZygqoSINohYYi 2zrb3i3/7WtlIEFC7tlwyhgLmC1F7T6KQ1C520pZbhjEW9YMM0kWq/RgPjf3ojMPAw89 2hzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=e2phenAZxeF2KbNSOo1NERscTLD4PWbM1r8NWK9H0Mc=; b=Wd3Q8tpMiionJchPq1O3LvJXXtcNNBpCCV3T6AE8FoUwtfz1sTp6dlPavbJcAgEZWP CdJ4UOsrV7B9weoZ87DGPDRFPCOq9r0hQBmYqsKJ7rDMH76NAfYKBV1ZnCrysllQONX3 2v2ampY2IjYv5yAyYItxCM/0DjC2x+anrU4qzZdTgSvQKiGsr3WIVIF6rhnWcUrnSYlO 4B1J1P61mPsvx/QIk5pI2HG0z1+1/1S24ElNQqAx2VvDcSyAvqEs91qBTEEizsZ5sXfQ HpRskEmjxZZx8J7FeeVKHC0o3D2EbhAlfuHFXoZ0kPSr3/znRMYkOtHopBEBIJ71OvAq xXFw== X-Gm-Message-State: AGi0PuagaBg9HyyHadXUWCzXwVGyWmAqmV/JPziSmcLaXGNBNs501R1a gdamXdPXuy/fd2Y/pELNhyU= X-Google-Smtp-Source: APiQypJhIdMx4ieZRnruocwymJxBayNZ6ueMCPiCIHa2GtI68SU+Qczn5e3/aV1eV5WQtrKVVFU+ag== X-Received: by 2002:ac2:4da7:: with SMTP id h7mr10740384lfe.95.1586796874423; Mon, 13 Apr 2020 09:54:34 -0700 (PDT) Original-Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id s7sm8422584lfb.40.2020.04.13.09.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2020 09:54:33 -0700 (PDT) In-Reply-To: <85pncbz80d.fsf@gmail.com> (Noam Postavsky's message of "Mon, 13 Apr 2020 12:05:06 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178322 Archived-At: On Mon, 13 Apr 2020 12:05:06 -0400 Noam Postavsky wrote: >> Right, because that was just an error on my part: `time-subtract' does >> in fact exhibit the problem. But its alias `subtract-time' doesn't, even >> when advised explicitly. I guess advices ignore aliases (i.e. pass >> through to the real definition)? > > Seems to be the opposite: the advice applies only to the alias, so since > elp uses the time-subtract name, advising subtract-time doesn't cause > problems. Indeed, thanks :-D I wonder what the best way forward is here. (info "(elisp) Profiling") states that elp "is limited to profiling functions written in Lisp, it cannot profile Emacs primitives". So given that of the problem-makers only `error' is a Lisp function, the simplest solution would be just replacing `special-form-p' with `subrp' in `elp-profilable-p', thus disallowing instrumenting primitives altogether. If we want to preserve the partial support for primitives, do we want to support as much as possible, e.g. by runtime-checking if `elp--make-wrapper' is compiled and determine the set of problem-makers dynamically, or do we just update the static `elp-not-profilable' list conservatively (i.e., including _all_ functions called from the wrappers, to make sure they don't cause problems even when `elp--make-wrapper' is run interpreted)? --=20 =C5=A0t=C4=9Bp=C3=A1n