From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#40693: 28.0.50; json-encode-alist changes alist Date: Sun, 19 Apr 2020 01:13:04 +0200 Message-ID: <87o8roxu9r.fsf@web.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="91009"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ivan Andrus , 40693@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 19 01:14:58 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPwfq-000NUh-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Apr 2020 01:14:58 +0200 Original-Received: from localhost ([::1]:34278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPwfp-0003GD-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Apr 2020 19:14:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55826) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPwew-0003EE-SG for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 19:14:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jPwew-0004wt-Bf for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 19:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jPwev-0004wS-UD for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 19:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPwev-0007lf-Pq for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 19:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Apr 2020 23:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40693 X-GNU-PR-Package: emacs Original-Received: via spool by 40693-submit@debbugs.gnu.org id=B40693.158725159129773 (code B ref 40693); Sat, 18 Apr 2020 23:14:01 +0000 Original-Received: (at 40693) by debbugs.gnu.org; 18 Apr 2020 23:13:11 +0000 Original-Received: from localhost ([127.0.0.1]:43762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPwe7-0007k8-Im for submit@debbugs.gnu.org; Sat, 18 Apr 2020 19:13:11 -0400 Original-Received: from mout.web.de ([212.227.15.3]:45185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPwe5-0007jr-DI for 40693@debbugs.gnu.org; Sat, 18 Apr 2020 19:13:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587251582; bh=3ygIdZUry1gSP6RWSQkQBWz+pbUZDzBkNI0/tsHM9Eg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=NSAe4TXyOCmRYdrWz65ftp2/ZhO4OMxkzuWKCB7+2eneyd7PNenGd/rBV7Ugkdtaw FZSJ86aHu267/1IpYs9Zm0n8dgLnfLwZoS9uNa1+yfv0g4OyaoF0GfCDXFMK3HUfwh ZQ1eoif2K/pV7P3CKyTg7/8vJqjo0qzWqhNhTziA= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.98.99.7]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lp712-1inKdG1xFE-00eqUs; Sun, 19 Apr 2020 01:13:02 +0200 In-Reply-To: (Dmitry Gutov's message of "Sat, 18 Apr 2020 20:29:03 +0300") X-Provags-ID: V03:K1:7WxnKm5WhM3N+Ab9rp1f0eQ81m9BdVR7Scf4IK86/7r+9om8GcB J8yHxpbcFupqQPpsAPwvNN/+QiQItzngdEo8igiRbmfEw63Vje/t+vYhP3l4jwpqbwe6CC/ AdhwiahlcSpCiu+7P/SKpm6cLMyaCNge4JVVpprmPqjVZq+PDEXvPFwua5nSPKax8d3TaIP 0h9KBbj9OqzN8pjCCA3mg== X-UI-Out-Filterresults: notjunk:1;V03:K0:NWfliVxU9SM=:vgp09/hm68OwBvrA93Xgx/ psfAqp89YVD+PvFgY37sD20YMsuPW1TwMhrD4ptIt7MPfkmmqxAjb0fFrGtlulutfNEpn1eDm Xo56pYPrzfoJ2pMQwNCkv2OUAGF77gA5YdVzwh0kzuk22TJd9zwEucWmajBrLPdXVJobQKpNl hIYqSulVBMrMB0WkwH6J2KekKKJuD/VtLFS0TdPMFutN3T+xNPfmeh71fYldhU1GeM6K88M/k yHahlUozuwBpqxUNCVYBzT+IrCLJwO5vuDdcsXRhWMkqEYYkwEWzqjYsYq9H8HgPG4uTjuvml XFKpSGFako9KWNgCf5Gtxd9/3HBpjix2vgYGoqOgGDIm2LWQcM8yCTzAmPTvAt05oAW19eZ1s 6+cxh5twR67daoMDlwpVDkwTPEWQqtvo+iE4Wo39naaFOKPMiwwfLaupBvEgJHkPAv7UC6LW4 Rc3LVtUQjf6rQeK58KRXExM5QZ80x5Vy3CHjOBylLX4dUTGExbuHB9TBwdt5N8N4xdcf+mu3u 6SR3+LuNHg1srbWREnWM8Vk7Df59Jdfjjjnf5Sc1Le2cp/4rk3+CCelD+WNj7s7txKSJirA5c PrFSZRWySMBzxMD8TgOpVv7dbhfnAj7CE07Jpy1oY2lvxslcexkf4AUp9LyGqYMm6kEk9ICi6 FHIoBiGWPp2kfuva8JpoWkolmmWi7mpCbddFwbgBYjuPrCL0SbbRfxx5QC7e5o8pdPNYLigHT D1gKYKZH1TLjiaA4mgU/gnnDzKxNlJrLcMB9dZBE1NEdQ4TYgIWjRH8WdBpGWNogTc5ws/v+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178605 Archived-At: Dmitry Gutov writes: > diff --git a/lisp/json.el b/lisp/json.el > index 18d7fda882..b65884f913 100644 > --- a/lisp/json.el > +++ b/lisp/json.el > @@ -564,9 +564,10 @@ json-encode-alist > "Return a JSON representation of ALIST." > (when json-encoding-object-sort-predicate > (setq alist > - (sort alist (lambda (a b) > - (funcall json-encoding-object-sort-predicate > - (car a) (car b)))))) > + (sort (copy-sequence alist) > + (lambda (a b) > + (funcall json-encoding-object-sort-predicate > + (car a) (car b)))))) > (format "{%s%s}" > (json-join > (json--with-indentation Why? Isn't this a classical example of modifiable code? After some iterations (symbol-function 'fun-withdraw) => (closure (t) (amount) (json-encode-alist (cons (cons 'tamount amount) '((const . some-constant) (tamount . 12) (tamount . 12) (tamount . 12))))) So the problem is in the implementation of `fun-withdraw', not in that of `json-encode-alist' or `sort'. I mean, it's really an example of an ugly trap, but how is `json-encode-alist' different from other functions working with lists that would exploit the same problem? Michael.