From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest Date: Mon, 15 Jun 2020 01:55:58 +0300 Organization: LINKOV.NET Message-ID: <87o8plb6kh.fsf@mail.linkov.net> References: <87ftbzva1f.fsf@rub.de> <877dxb4hzh.fsf@mail.linkov.net> <87mu66i5gl.fsf@mail.linkov.net> <8d5d6374-26f8-49b7-badd-c676c9622ea8@default> <87k10dz051.fsf@mail.linkov.net> <87h7vewp6i.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="74417"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41338@debbugs.gnu.org, Stephen Berman , Konrad Podczeck To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 15 01:56:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkcU1-000JG7-TC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jun 2020 01:56:13 +0200 Original-Received: from localhost ([::1]:39938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkcU0-0003wA-7c for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jun 2020 19:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkcTr-0003uP-GR for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 19:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33189) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkcTr-0006jw-81 for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 19:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkcTr-00052i-7W for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 19:56:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jun 2020 23:56:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41338 X-GNU-PR-Package: emacs Original-Received: via spool by 41338-submit@debbugs.gnu.org id=B41338.159217892719290 (code B ref 41338); Sun, 14 Jun 2020 23:56:03 +0000 Original-Received: (at 41338) by debbugs.gnu.org; 14 Jun 2020 23:55:27 +0000 Original-Received: from localhost ([127.0.0.1]:44724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkcTH-000514-K0 for submit@debbugs.gnu.org; Sun, 14 Jun 2020 19:55:27 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:64387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkcTF-00050d-Um for 41338@debbugs.gnu.org; Sun, 14 Jun 2020 19:55:26 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 5D49A40004; Sun, 14 Jun 2020 23:55:18 +0000 (UTC) In-Reply-To: <87h7vewp6i.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 14 Jun 2020 01:56:05 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181971 Archived-At: >> isearch uses overriding-terminal-local-map, so the proper test case is: >> >> (setq overriding-terminal-local-map >> (let ((map (make-keymap))) >> (define-key map [delete-frame] >> (lambda (&rest ignore) >> (interactive) >> (message "DELETE-FRAME"))) >> (define-key map "!" >> (lambda (&rest ignore) >> (interactive) >> (message "!"))) >> map)) >> >> and indeed typing '!' you get the message, >> but no message when clicking the `X' icon. > > The docstring of 'overriding-terminal-local-map' says: > > Per-terminal keymap that takes precedence over all other keymaps. > > so maybe this is right for a *per-terminal* keymap not to react > to window events such as clicking the `X' icon? If there is no bug here, then I see two possible solutions for isearch: 1. use special-event-map in isearch.el the same way as isearch.el uses overriding-terminal-local-map; 2. use the hook ‘delete-frame-functions’ to explicitly exit isearch.