From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization Date: Tue, 23 Jun 2020 02:50:35 +0300 Message-ID: <87o8pa64l8.fsf@mail.linkov.net> References: <0e6ad4aefa2743f1b0d6ba4315a9e91b@VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM> <44423F99-0143-4F4E-A4FC-D29B922A48A2@yellowfrog.io> <87o8pl9rfn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: "Basil L. Contovounesios" , "41766@debbugs.gnu.org" <41766@debbugs.gnu.org>, Simon Lang , Dmitry Gutov To: Simon Lang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 23 02:17:06 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnWcb-000QYi-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 02:17:05 +0200 Original-Received: from localhost ([::1]:35790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnWca-0007u5-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 20:17:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnWba-00074Z-DJ for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnWba-00031v-0N for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnWbZ-00071P-RG for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2020 20:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jun 2020 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41766 X-GNU-PR-Package: emacs Original-Received: via spool by 41766-submit@debbugs.gnu.org id=B41766.159287133426948 (code B ref 41766); Tue, 23 Jun 2020 00:16:01 +0000 Original-Received: (at 41766) by debbugs.gnu.org; 23 Jun 2020 00:15:34 +0000 Original-Received: from localhost ([127.0.0.1]:34956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWb8-00070a-Dz for submit@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:34 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:42755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnWb5-0006zw-Uy for 41766@debbugs.gnu.org; Mon, 22 Jun 2020 20:15:32 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2BA68240005; Tue, 23 Jun 2020 00:15:23 +0000 (UTC) In-Reply-To: (Simon Lang's message of "Mon, 22 Jun 2020 19:09:12 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182300 Archived-At: > I changed it to defcustom because this is how I currently use it and > no one had strong feelings about it. > Do you want me to change it to devfar again? Or is it fine as it is? If you don't want to change it to devfar in your patch, then for users there should be an easy way to revert their customization to the default value. This would be possible by using such menu of possible values: (defcustom grep-match-regexp "\033\\[0?1;31m\\(.*?\\)\033\\[[0-9]*m" "Regular expression matching grep markers to highlight. It matches SGR ANSI escape sequences which are emitted by grep to color its output. This variable is used in `grep-filter'." :type '(choice (regexp :tag "GNU grep" "\033\\[0?1;31m\\(.*?\\)\033\\[[0-9]*m") (regexp :tag "ripgrep" "\033\\[[0-9]*m\033\\[[0-9]*1m\033\\[[0-9]*1m\\(.*?\\)\033\\[[0-9]*0m") (regexp :tag "Other grep programs")) :version "28.1")