From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving Date: Sun, 19 Jul 2020 04:16:11 +0200 Message-ID: <87o8ocuu50.fsf@gnus.org> References: <87a738ql1z.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40704@debbugs.gnu.org, Eric Abrahamsen To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 19 04:17:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwyt4-0005qq-3k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jul 2020 04:17:10 +0200 Original-Received: from localhost ([::1]:59106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwyt2-0000l6-Kt for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Jul 2020 22:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwysw-0000kV-Nu for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2020 22:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwysw-0000jG-Df for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2020 22:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jwysw-0000GW-9J for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2020 22:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jul 2020 02:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40704 X-GNU-PR-Package: emacs Original-Received: via spool by 40704-submit@debbugs.gnu.org id=B40704.1595124986962 (code B ref 40704); Sun, 19 Jul 2020 02:17:02 +0000 Original-Received: (at 40704) by debbugs.gnu.org; 19 Jul 2020 02:16:26 +0000 Original-Received: from localhost ([127.0.0.1]:59720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwysM-0000FS-18 for submit@debbugs.gnu.org; Sat, 18 Jul 2020 22:16:26 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwysJ-0000FC-Uu for 40704@debbugs.gnu.org; Sat, 18 Jul 2020 22:16:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JyepkZrZNqTuInXtesdneyMTkzBDlpTiNcSPy9GNN/Q=; b=boZ7v9mm7882yJflGqz7/LPssk O2bJL3rXxHjsTmnPMhopRXh5zfs/hZoHKjRblEUBIElBTqHPxs2ws6mffvslypMM5AsUsGyi8J+NA 38HBmAsQPjPRQ2378reHDrakNdG6QZjkF2W9bN//ciliVhc5abK1yjhFiujihCCog/10=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwys8-00083J-MG; Sun, 19 Jul 2020 04:16:17 +0200 In-Reply-To: <87a738ql1z.fsf@web.de> (Michael Heerdegen's message of "Sun, 19 Apr 2020 04:14:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183193 Archived-At: Michael Heerdegen writes: > (3) I also decided to change `eieio-override-prin1' to print hash tables > "by hand" from Lisp. The eieio-persistent requires to modify how > elements in the hash tables are printed, and the current way of doing > this (make a copy of the complete table, change the elements, prin1 and > re-read the result) is not only hackish but also inefficient (it does > this recursively for nested tables). Yeah, the current implementation seems maximally inefficient... But I guess this copies functionality found elsewhere? > + (princ "#s(hash-table size ") > + (prin1 (hash-table-size thing)) > + (princ " test ") > + (prin1 (hash-table-test thing)) > + (princ " weakness ") > + (prin1 (hash-table-weakness thing)) > + (princ " rehash-size ") etc So if the other printer changes, then this has to change, too? That seems kinda brittle -- there should at least be references between the two printers with a note to keep them updated if one of them changes. > diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el > index 480ed80ef8..4ac3c84a80 100644 > --- a/lisp/gnus/gnus-registry.el > +++ b/lisp/gnus/gnus-registry.el > @@ -398,6 +398,7 @@ gnus-registry-save > (interactive) > (let* ((file (or file gnus-registry-cache-file)) > (db (or db gnus-registry-db)) > + (gc-cons-threshold (max gc-cons-threshold (* 800000 500))) > (clone (clone db))) > (gnus-message 5 "Saving Gnus registry (%d entries) to %s..." > (registry-size db) file) Could this have adverse consequences for people with low memory? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no