From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41060: [PATCH] Use write-region when saving recentf file Date: Sat, 08 Aug 2020 14:00:18 +0200 Message-ID: <87o8nl2vql.fsf@gnus.org> References: <87zhapx94a.fsf@bulbul> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14156"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41060@debbugs.gnu.org To: philip@warpmail.net (Philip K.) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 08 14:01:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4NXH-0003av-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 14:01:16 +0200 Original-Received: from localhost ([::1]:49540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4NXG-00035T-VT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 08:01:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4NX4-00032e-Nh for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 08:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4NX4-0002IW-Dp for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 08:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4NX4-00043A-Bz for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 08:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Aug 2020 12:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41060-submit@debbugs.gnu.org id=B41060.159688804414531 (code B ref 41060); Sat, 08 Aug 2020 12:01:02 +0000 Original-Received: (at 41060) by debbugs.gnu.org; 8 Aug 2020 12:00:44 +0000 Original-Received: from localhost ([127.0.0.1]:58373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NWX-0003Xm-Lm for submit@debbugs.gnu.org; Sat, 08 Aug 2020 08:00:44 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NWW-0003RS-7V for 41060@debbugs.gnu.org; Sat, 08 Aug 2020 08:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aGeBE8QQS/hIErmbM3LfJMzlXlb5UVMuUO3EYixaRQk=; b=Br8QJo9Vw0A2b/dMxjjYsjAynp HMvdAXALvGhuc/POK6lkIOm9wW1xZw1Y8Aq5+IQQmo5pExEfuMdqhffVfwx/ivsPPcShk035l/q+T YmZkvlT+eR+6bXcIxLvlE83BSF5qdVZSGfsQ7Gu/Q79vPx/HfhkueCwTDOSgOPq5P5Pk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4NWN-0003xL-JL; Sat, 08 Aug 2020 14:00:22 +0200 In-Reply-To: <87zhapx94a.fsf@bulbul> (Philip K.'s message of "Sun, 03 May 2020 18:43:01 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184333 Archived-At: philip@warpmail.net (Philip K.) writes: > I've been playing around with enabling "version-control" for backups, > and what I have been noticing is that the ~/.emacs.d/recentf file has > had a lot of backups, far more that regular files that I use. My > understanding is that this happens because recentf currently uses > write-file (that in turn uses the backup'ing save-buffer) instead of > directly writing the temporary buffer to the disk. > > This patch does just that, replacing write-file with write-region, > because I argue that an automatically generated file doesn't need > backups. Eli was against it, but Richard was for it, and it does seem inconsistent with how Emacs does it with other files, so I went ahead and applied it. Feel free to revert if anybody strenuously disagrees with this. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no