From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#26969: 26.0.50; diff-changed invisible by default Date: Mon, 24 Aug 2020 17:10:24 +0200 Message-ID: <87o8n084gv.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39289"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 26969@debbugs.gnu.org, Justin Burkett To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 24 17:11:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAE7o-000A7N-S4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 17:11:08 +0200 Original-Received: from localhost ([::1]:54864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAE7n-0004sY-UY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 11:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAE7i-0004sQ-Io for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 11:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAE7i-0001qw-A7 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 11:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAE7i-0004u9-69 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 11:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26969 X-GNU-PR-Package: emacs Original-Received: via spool by 26969-submit@debbugs.gnu.org id=B26969.159828184518819 (code B ref 26969); Mon, 24 Aug 2020 15:11:02 +0000 Original-Received: (at 26969) by debbugs.gnu.org; 24 Aug 2020 15:10:45 +0000 Original-Received: from localhost ([127.0.0.1]:58901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAE7R-0004tT-B6 for submit@debbugs.gnu.org; Mon, 24 Aug 2020 11:10:45 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAE7P-0004tC-DP for 26969@debbugs.gnu.org; Mon, 24 Aug 2020 11:10:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jge50Bo8FMU7BM12jw21JATjUIX1/04iqVvffBpSuRk=; b=b53UWsqYplEsPq7Qq98dkOP7Lg 5qqPhGG08rM8moKyZfyP9OQqynFaPuvtfpkD6mq3MeXosObZ+xhmzUga4IEejsgDawd1M8VmV6mE+ wwTyuxkRTCbOQ6lR3msDb2BmlPsOkNUdMGhjudvscgYDbAmhY//Qf2o7cK/KGCGo/TvE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAE78-0007up-1O; Mon, 24 Aug 2020 17:10:36 +0200 X-Now-Playing: Sevdaliza's _ISON_: "Grace" In-Reply-To: (Stefan Monnier's message of "Wed, 17 May 2017 15:12:50 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186168 Archived-At: Stefan Monnier writes: > Nowadays the `diff-changed` face is defined to be "invisible" (i.e. the > text is displayed identically with or without that face). > IOW it can only be used as a parent of diff-added or diff-removed (or > some other such face). > > This is a bad idea since in cases such as vdiff.el where some changes > are neither additions nor removals, it would make sense to highlight the > buffer as just "changed" and using that face is a natural choice. > > I suggest the patch below for that. It is designed such that it should > make no visible difference to users of diff-added and diff-removed since > these faces override the parts that are set by my patch in diff-changed. That does sound a bit fragile... > Another option would be to introduce a new face (not sure how to call > it, maybe diff-unspecified-change, maybe?) which inherits from > diff-changed as well. I think that sounds more straightforward? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no