From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH] Date: Tue, 15 Sep 2020 20:47:05 +0200 Message-ID: <87o8m6ri6u.fsf@gmx.de> References: <20200915040728.77ufv7g6bekvrzqa@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43412@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 15 20:48:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIG0F-000A9a-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 20:48:31 +0200 Original-Received: from localhost ([::1]:33062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIG0E-0003Lz-O2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 14:48:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIFzm-0003K8-1N for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 14:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49025) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIFzl-0007CW-Nd for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 14:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIFzl-00007D-M9 for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 14:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Sep 2020 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43412-submit@debbugs.gnu.org id=B43412.1600195635389 (code B ref 43412); Tue, 15 Sep 2020 18:48:01 +0000 Original-Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 18:47:15 +0000 Original-Received: from localhost ([127.0.0.1]:60571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIFz1-00006B-6u for submit@debbugs.gnu.org; Tue, 15 Sep 2020 14:47:15 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:58589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIFyz-00005x-6R for 43412@debbugs.gnu.org; Tue, 15 Sep 2020 14:47:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600195626; bh=espwa/NglIJZSxJcAgMz7FStX+OHTtQOHxlhqo4ZwIY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=DxEVHKK08qfIxusg7aWaZR2e2nvZZZytKdx70qRw3AT3rTXGkYvPonB6Rn28OnlsD M2g/DfVZwp+CxECoxknzbMpVgEfzUQb0clrHijkUuGq0ZM4U73sLH7H0AmiEi8j6Fd fZgs0V4ShoShY/g6IJt/u8b1+tBsguUswHBGcsMo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.40.68]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N1OXZ-1kTlbt2RMx-012m3Y; Tue, 15 Sep 2020 20:47:06 +0200 In-Reply-To: <20200915040728.77ufv7g6bekvrzqa@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 15 Sep 2020 00:07:28 -0400") X-Provags-ID: V03:K1:SYzCequkWVgoC0JVN5fX8VR1+15cMfljI9agY1EcsTgCUEDfWsM AcrtATyfx1ndfbYFVPf864maxuYlbY+KhTSJSJhX+KzqJS/0HbMxtavbUUJF5xBNXdCrEJA iH8HCxCDoB7K4VS+SBcjmv6maDP4rHCQnngGT0HjwjKOcn1cSdKIRIfy21AlbW67qJKiv1z MdAknvmYWWQtfJAKJe9yQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:8+TmEPnaSJQ=:TZ/p/oktswuuuOJjZlsGXH OZPIec1ocpvyj9mShnpxfAIi2jSlwu4O/AWeKOEBIvxCeG2zi7YjYmDrZcGxUnLOpCereqvJe ufCSrCltevkMko61w+4LKlKOV7S0hOqccD3s4JY6WWbj1iPI/hzulSc3xpm8CqmIGM153CsKl aDr6jRyuoPkk6s2mnB2ZnWoJ8RNady8ZscbPTLrx5qeqxlPgYR318IZzy3odLfQMjy07WQ4HD oBiTg/KLsQiQnBIWNeasiyEfkI3kFYqmgQHUGQOQbipr+Dvwo0iNKGtfeeU4J/6ySj01bLbN7 5W8Tfiod4pNznzEqGYA1cNw5UEkm1ftG+h4mODF9dFCbIMlI5WxgLgU6WlV3R2ZyIWO73X3x3 QdfTBqqUm3jZlj2EQ7y6Z3qjOlrD4bmlpo4vrMRgA2QI8zvVh7GgLpc/MtmCPbd7JR+7Sbm2n FuMYWkVpT8UcRrlbfePmDINGSoKpF+ETMopuWvYC/L3ijgMOnRykXoDhC3Eyy8oF6wgMgWQ3u 7D3hdgcrxRPaxjMIDnaaMR+Nl6lNM1kaeJXAkBNsVdSS48Au/JupiaRaiZj87qjT1Hdge3csI VbEOhiRVrveHjZMa8b+GmPqcpdV3qvuydeLgqbW+ftuusKpGPXnRPOHPxuBORd22FPOpw3Xgt u2npl6xZwwGwX1lJvFcKnopJ1l9jTbNnvol5vqRrMZF8Qv68rPUC+fVN6tTLGW+xd6CjCw7NH u4vb+tregMJPAnRaDuz5MhThxbB22t1mz8c/QvcBMECQe8IvlNza5ofW5JnOUI3wdSFG8yGs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188148 Archived-At: Boruch Baum writes: Hi Boruch, > The attached proposed patch adds a defcustom and makes a change to two > existing functions in order to allow a user the option to only have > autorevert mode operate on visible buffers. The change to function > 'after-find-files' may also fix a bug (or change behavior) in that > sometimes when being prompted to manually revert a buffer that had been > in auto-revert-mode, the auto-revert-mode status would be lost, ie. set > to nil. I haven't tested your patch, but I'm asking myself whether it cooperates with autorevert triggered by file notifications. That is, if a file changes on disk, a notification event is sent, and autovert happens. If autorevert does not happen because the buffer is not visible, this event will be lost, and no autorevert will happen later on when the buffer becomes visible. Have you tested this scenario? Best regards, Michael.