From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Hugh Daschbach Newsgroups: gmane.emacs.bugs Subject: bug#43252: 27.1; DBus properties lack type hints or overrides Date: Thu, 24 Sep 2020 21:16:18 -0700 Message-ID: <87o8lu8p9p.fsf@ccss.com> References: <87v9gqquct.fsf@ccss.com> <87v9gm9x9i.fsf@ccss.com> <871rj9k78r.fsf@gmx.de> <87imclwow5.fsf@gmx.de> <87pn6t9rbq.fsf@ccss.com> <87y2lggzvd.fsf@gmx.de> <87h7rzadlo.fsf@ccss.com> <87k0wtrir2.fsf@gmx.de> <87een19x9n.fsf@ccss.com> <87a6xor25b.fsf@gmx.de> <87bli49rem.fsf@ccss.com> <87h7rva0ku.fsf@gmx.de> <875z8aa1bm.fsf@ccss.com> <87ft7c8p4k.fsf@gmx.de> <87imc7jqms.fsf@gmx.de> <87zh5i8o9h.fsf@ccss.com> <87eemt67eg.fsf@gmx.de> <87wo0l8908.fsf@ccss.com> <87wo0kielj.fsf@gmx.de> <87r1qr98sf.fsf@ccss.com> <87r1qrimqf.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35585"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.5; emacs 27.1 Cc: 43252@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 25 06:17:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLfAT-00099C-JB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 06:17:09 +0200 Original-Received: from localhost ([::1]:59034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLfAS-0005Kt-M9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 00:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLfAM-0005Jm-Eo for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 00:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLfAM-0007PL-5q for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 00:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLfAM-0007Uh-0r for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 00:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Hugh Daschbach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Sep 2020 04:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43252 X-GNU-PR-Package: emacs Original-Received: via spool by 43252-submit@debbugs.gnu.org id=B43252.160100739428770 (code B ref 43252); Fri, 25 Sep 2020 04:17:01 +0000 Original-Received: (at 43252) by debbugs.gnu.org; 25 Sep 2020 04:16:34 +0000 Original-Received: from localhost ([127.0.0.1]:42311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLf9u-0007Ty-Ce for submit@debbugs.gnu.org; Fri, 25 Sep 2020 00:16:34 -0400 Original-Received: from mail1.ccss.com ([159.203.255.73]:36450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLf9r-0007Tk-J7 for 43252@debbugs.gnu.org; Fri, 25 Sep 2020 00:16:33 -0400 Original-Received: by mail1.ccss.com (Postfix, from userid 114) id ECA55BF8F6; Thu, 24 Sep 2020 21:16:25 -0700 (PDT) Original-Received: from ccss.com (unknown [192.168.76.11]) by mail1.ccss.com (Postfix) with ESMTP id 5AFF3BF8F4; Thu, 24 Sep 2020 21:16:25 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by ccss.com (Postfix) with ESMTP id 319B2176129B; Thu, 24 Sep 2020 21:16:25 -0700 (PDT) Original-Received: from ccss.com ([127.0.0.1]) by localhost (ccss.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5u_B0dURsv7c; Thu, 24 Sep 2020 21:16:19 -0700 (PDT) Original-Received: from klaatu (klaatu.lan [192.168.42.3]) (Authenticated sender: hugh) by ccss.com (Postfix) with ESMTPSA id 448D517606BF; Thu, 24 Sep 2020 21:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ccss.com; s=mail; t=1601007379; bh=YR5pJMK8IHd8yYa9ZeO3kdmbNTnp7KxnFcdO/pbx774=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=VAutfeH/sBZsdVXj/8TvosA84+2Spfa3RQi1xSBliySUwReRr3ZKXKlFUhc3xFpEH MEsbEUhCN0Qd3Ss2X3pYovVsrEJLQC4F655z7p62Cs8qeTJ9EFMYkl/6Lxnz883tTD BNGtjQeviiON6xPPJTfwJVF+ljJNeRXu5PyVmd6MDNHwfnmoTQTFmVRWBg9uIKE63Y RWJeXDWy3V7KIWKfaHusSliaLiYeepiGuId/T4DwhkeCsgjFV7Q52C2D69QvBE6jgB +pVQHj4xUpd76aRUEJk8le+x7R+85jmLnkQiJRejdhljY+y3Nbe4nidn8Wgdvm1Nz4 EvaEqUVQm+1/g== In-reply-to: <87r1qrimqf.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188923 Archived-At: Michael Albinus writes: > Hugh Daschbach writes: > > Hi Hugh, > >> I think I've addressed all the issues you pointed out. Let me know if >> there's something that still doesn't look right. > > I've roughly scanned the patches, they look almost OK. Let's wait now > for appearing your name on the copyright file. > > Anyway, here's my nit of the day: > >> * test/lisp/net/dbus-tests/org.gnu.Emacs.TestDBus.xml: New test data. > > This shall be dbus-resources. Thanks. Fixed. Will wait for the paperwork to clear. Then will rebase and send you a final copy of the patches. >> Thanks >> Hugh > > Best regards, Michael. I've taken a brief look at performance of the introspection tests. The long pole seems to be ERT, rather than the tests themselves. Running the profiler while running ert showed The cpu profiler report for running dbus-test07-introspection breaks down something like: - GC - 30% - dbus-* - 30% - ert-* - 40% So I pulled introspection tests out into a separate file, redefined `should', and reran dbus-test07-introspection. It completed almost instantly. I wrapped the body of dbus-test07-introspection in a dotimes form with 50 iterations. That completes in roughly 1.1 seconds. Comparing runtime and GC cycles for a single run, running with ERT: 2 gcs in 2.228295 sec running w/o ERT: 1 gcs in 0.036733 sec Those numbers come from: (let ((start (current-time)) (gcs gcs-done)) ;; test program call (message "%d gcs in %02f sec" (- gcs-done gcs) (float-time (time-since start)))) I'm not well versed in chasing Emacs performance issues, bit this looks to me more like testing than introspection overhead. Any suggestions? Cheers, Hugh