From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file Date: Fri, 30 Oct 2020 14:28:59 +0100 Message-ID: <87o8kjhmg4.fsf@gnus.org> References: <87wnz9pd2j.fsf@runbox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24901"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44303@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 14:30:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYUU0-0006Ko-8r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 14:30:20 +0100 Original-Received: from localhost ([::1]:58020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYUTz-0007NK-B3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 09:30:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYUTi-0007Mn-FY for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:30:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYUTi-0007Vz-46 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYUTh-0007rS-Vu for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 13:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44303 X-GNU-PR-Package: emacs Original-Received: via spool by 44303-submit@debbugs.gnu.org id=B44303.160406456030132 (code B ref 44303); Fri, 30 Oct 2020 13:30:01 +0000 Original-Received: (at 44303) by debbugs.gnu.org; 30 Oct 2020 13:29:20 +0000 Original-Received: from localhost ([127.0.0.1]:56656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUT1-0007pv-PR for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:29:20 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUSz-0007pg-Av for 44303@debbugs.gnu.org; Fri, 30 Oct 2020 09:29:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h6aO0YowkPyhY3X9MvCBARAfRDNWr6uje0VLaqFL2ys=; b=naKdNfTgD3r+sm9/mADZCEvo4a BbMtPi8tTk3C909U893Y9hpL6UKa1dvoc4+DdwudJYA+ic2ijklm16bTHFz4IO3VEzNLDDbPG8kHK +o08H942UgYVCzTlA3tT4Sd6P1CJILoX38I0dUvQ+dxMTt/mx5h8z1n/TE/3rBRNee9w=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYUSj-0000ZQ-02; Fri, 30 Oct 2020 14:29:11 +0100 X-Now-Playing: Noveller's _Arrow_: "Thorns" In-Reply-To: <87wnz9pd2j.fsf@runbox.com> ("Simen =?UTF-8?Q?Heggest=C3=B8yl?="'s message of "Thu, 29 Oct 2020 10:59:48 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192095 Archived-At: Simen Heggest=C3=B8yl writes: > Given a file named 'test.json' with the following content: {} > >>>From 'emacs -Q', visit the file and call 'json-pretty-print-buffer'. > > The buffer stays unchanged as expected since the pretty printed content > is identical to the original. The buffer is not marked as modified (also > expected), but a spurious lock file '.#test.json' has been created. Yup. It's this code in Freplace_buffer_contents: if (!inhibit_modification_hooks) { prepare_to_modify_buffer (BEGV, ZV, NULL); specbind (Qinhibit_modification_hooks, Qt); modification_hooks_inhibited =3D true; } prepare_to_modify_buffer creates the backup file. But is that even needed here? Don't the later Finsert_buffer_substring/del_range_both functions do the necessary bookkeeping? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no