From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Leon Vack Newsgroups: gmane.emacs.bugs Subject: bug#45340: erc-services.el: Auth-source support for passwords Date: Wed, 20 Jan 2021 11:42:05 +0100 Message-ID: <87o8hj28le.fsf@sol.hw.lgcl.de> References: <87v9cw7np1.fsf@sol.hw.lgcl.de> <4311421.VgBTkc7HA1@ravel> <87mtxalals.fsf@sol.hw.lgcl.de> <1936038.bl7DLxgNLY@ravel> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 45340@debbugs.gnu.org, bandali@gnu.org To: Olivier Certner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 20 11:43:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2AxI-0000bR-UA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 11:43:17 +0100 Original-Received: from localhost ([::1]:53466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2AxI-0001kO-0z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 05:43:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2Ax3-0001k1-SM for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 05:43:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2Ax3-00064d-LC for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 05:43:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2Ax3-0004ae-K6 for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 05:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leon Vack Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jan 2021 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45340 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, 45340@debbugs.gnu.org, Amin Bandali , Lars Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.161113933917590 (code B ref -1); Wed, 20 Jan 2021 10:43:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Jan 2021 10:42:19 +0000 Original-Received: from localhost ([127.0.0.1]:53023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2AwM-0004Zd-OS for submit@debbugs.gnu.org; Wed, 20 Jan 2021 05:42:19 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:47482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2AwL-0004ZW-HG for submit@debbugs.gnu.org; Wed, 20 Jan 2021 05:42:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2AwL-0001dy-AD for bug-gnu-emacs@gnu.org; Wed, 20 Jan 2021 05:42:17 -0500 Original-Received: from out1.migadu.com ([91.121.223.63]:46436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2AwH-0005oL-OB; Wed, 20 Jan 2021 05:42:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lgcl.de; s=key1; t=1611139326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BYuyZtNBvOck+Tmv1mtM5d5/+4JonNreLiHWCKspiM0=; b=Rt0eAHt963krrRlMoaV7pkxx/Uaov7i7DfNDxcuPRgUzO8p7bLpF1dGTFvlp61tB5ekbwT XMURmLaK6czoFNBQGwfA+of3omgrwLZMpT/VdIWMPQBpOzClOOg4x4fDTaBGf8EYMWb5wF 9B8tryf+USxak8Yyc60zsVQ6cknUvYcgmqSk615GfFb6TV+gdpm7d+ary7XL1W9zLr48dO 5VQKq1rTJwlxId4Q60ZuoNBNp2KJXwUCJTwk7qPuCPv+hyOBszg4xLwr8vIQL8vhv4x317 Yb1iKfwdmUNOapCRyr3Jmnv5o2aVDyVLWwZ/f1Lk/viUglpwlVY1Wrm3HybZqg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <1936038.bl7DLxgNLY@ravel> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: dev@lgcl.de Received-SPF: pass client-ip=91.121.223.63; envelope-from=dev@lgcl.de; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198255 Archived-At: Hello Olivier, sorry for the long time it took me to reply. Olivier Certner writes: > I also have some further suggestion, beyond this enhancement. I think it would > be even more useful that `erc-prompt-for-nickserv-password' is not required to > be nil for auth source (or `erc-nickserv-passwords', for that purpose) to be > used, but rather that, if search in `erc-nickserv-passwords' and auth source > (if enabled) fails, then prompting should be used as a last resort (if > enabled). I think this would cover all the use cases I can think of (with > proper settings of `erc-prompt-for-nickserv-password' and `erc-use-auth- > source-for-nickserv-password'). If more customizations are required, or just > for the sake of 'simplicity' (YMMV), than maybe replacing these booleans with > a single list indicating the means to get the password and their order could > be nice. > > What do people think? > I personally agree with you on this. Having to change `erc-prompt-for-nickserv-password' for `erc-nickserv-passwords' to have an effect caught me off guard in the beginning as well. The list of NickServ password sources seems like the more flexible solution, but would be a bit more complex to implement, considering how the current system works. Changing the precedence to `erc-nickserv-passwords', auth source and then prompt (if enabled), on the other hand, should be a rather simple patch. I think we should discuss this not on this bug, but on the emacs-erc mailing list before we change that. Regards, Leon Vack