From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Date: Thu, 21 Jan 2021 15:46:03 +0100 Message-ID: <87o8hijql0.fsf@gnus.org> References: <875z3suun0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24004"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 13692@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 21 15:47:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2bEs-000668-TJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 15:47:10 +0100 Original-Received: from localhost ([::1]:48026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2bEr-00029i-VD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 09:47:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2bEj-00028Y-W4 for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 09:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2bEj-00057e-Nh for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 09:47:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2bEj-0007WS-Iz for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 09:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jan 2021 14:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13692 X-GNU-PR-Package: emacs Original-Received: via spool by 13692-submit@debbugs.gnu.org id=B13692.161124037928859 (code B ref 13692); Thu, 21 Jan 2021 14:47:01 +0000 Original-Received: (at 13692) by debbugs.gnu.org; 21 Jan 2021 14:46:19 +0000 Original-Received: from localhost ([127.0.0.1]:57230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2bE3-0007VP-Er for submit@debbugs.gnu.org; Thu, 21 Jan 2021 09:46:19 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:58370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2bE0-0007VB-Sf for 13692@debbugs.gnu.org; Thu, 21 Jan 2021 09:46:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B6RcAc3tZckM2h+tV4P1xqTvY3YGgqTA01o1jX1MfnY=; b=kzFmsNkQCdpFzBKkaHZYAxXVkZ beEsFqHw+hC9metiiDwiCsHiAUjGmIdCrFIH1C/tPwmLn50Um68gD5rrCHDhWtfNbkAr6P9B53ki1 4kzb7CqOFndb0DPfduW1hDU8N39Z9uQ8yX5SkBczQkjXWkLtikhzJj54jmRZd/EKrHIs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2bDs-000641-4f; Thu, 21 Jan 2021 15:46:10 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEWXlpP+/v7o6+xN p/eZyfKCgX3T1teAfnp9e3d0b24eFhZUT1JGNjeiWyX///8QTMQsAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UBFQ4lJA6Ut7AAAAGiSURBVDjLxdK9TuNAEAfwNVIQQRQZFxYl68INZXgEHiAg+UIZu3BB hZCs3XQ00a6oUqEIUaArBzc0FCHNdSdneYFIvAuzgL8Sp6Bi5Gp+nv3PWmaMMQfWy+cu9dnOWrvf 758AGzD2ZxP6YCcGrUATjDfhlIqgwzoRbBa76rC9Vki3wSQM20Gl22HI20Cn4aAdRHgDP4M0vCrC 4wao8OLmW0a1MKZ0KApxE14HoYX8Et9PouooqbTWchrZvg+JX4KWBMqKa+UoKsGWFPLsE2I+ioqt Ugt6HAXgBnESxHExMRFDOmvC7+9IkqCcsFspraYeIkk8Cgqw7xNeHyLiC9D/VNxDyIlU4di5xIWh mWC32moo1VDx+8yYV3NXXnCmlaCHIkxDWHcm7LrXPcxySsGsAK9rP8nYOZ7TSIb4WAB43RltxW8X +JS/rfC5BCti6qLJs8X7KncqAG9vdt7DpzkuzSqDGtBMdIz/DaIpI74APL6PFEwp/5oA0PvcFdFZ h2/J+AaQLB+qiBqA9/Ca/20D8A6qiAaAN+ftAC5sAfhNqG31ARSB4felKw/AAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIxLTAxLTIxVDE0OjM3OjM2KzAwOjAwfdVHfQAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMS0wMS0yMVQxNDozNzozNiswMDowMAyI/8EAAAAASUVORK5CYII= X-Now-Playing: repository's _Depeche Mode_: "Black Celebration: The 12" Singles (5): A Question of Time (Limited Edition)/03-Black Celebration (Black Tulip Mix).mp3" In-Reply-To: (Dmitry Gutov's message of "Thu, 21 Jan 2021 05:08:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198315 Archived-At: Dmitry Gutov writes: > On 20.01.2021 05:58, Lars Ingebrigtsen wrote: >> So the suggestion is to remove the `[mouse-2]' binding in >> `vc-dir-mode'. > > I'm not sure, actually. Perhaps the complaint is about the mouse-1 > effect on status buttons. > > But the rest of my email is on the assumption that we're talking about > the mouse-2 binding. Depending on your settings, it's the same binding. I think the default is that mouse-1 and mouse-2 will work the same here (because of the (define-key map [follow-link] 'mouse-face) thing)? > I don't have a strong opinion about this feature, but it seems like it > was designed almost with the main goal of being non-discoverable. As > such, I don't think it has many users. > > It only works when you click on an empty space; if you click on a file > or directory name (which are highlighted as buttons and thus invite > you to click on them), using mouse-1 or mouse-2, you get to visit the > file instead. Only the "status" buttons work for that. It works on the status column, which normally has text like "edited " in it (if you've edited something) -- the button extends to the end of the column... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no