unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: haj@posteo.de (Harald Jörg)
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 46302@debbugs.gnu.org
Subject: bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code
Date: Thu, 04 Feb 2021 23:28:28 +0100	[thread overview]
Message-ID: <87o8gztqlv.fsf@hajtower> (raw)
In-Reply-To: <878s83objc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Feb 2021 20:52:55 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> haj@posteo.de (Harald Jörg) writes:
>
>> Finally, a workaround to set `font-lock-syntactic-keywords` is no longer
>> needed.  This eliminates a warning when compiling cperl-mode.el under
>> current Emacs.
>
> I don't get any warnings when compiling cperl-mode.el?

Ooops... Me neither.

I seem to recall a warning in the *Compile-Log* buffer that
`font-lock-syntactic.keywords' is an obsolete variable.  However, I
can't reproduce it :(

Did I hallucinate?  I had a look: The variable _is_ obsolete as of
font-lock.el:

(make-obsolete-variable 'font-lock-syntactic-keywords
                        'syntax-propertize-function "24.1")

Isn't `make-obsolete-variable` supposed to generate a compiler warning?
Or maybe I found the warning in C-h v font-lock-syntactic-keywords?
I'm confused.

> Anyway, the patch looks good to me, so I've applied it to Emacs 28.

Thanks!
-- 
Cheers,
haj





  reply	other threads:[~2021-02-04 22:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 19:21 bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code Harald Jörg
2021-02-04 19:52 ` Lars Ingebrigtsen
2021-02-04 22:28   ` Harald Jörg [this message]
2021-02-05  8:57     ` Lars Ingebrigtsen
2021-02-05 10:54       ` Harald Jörg
2021-02-05 11:03         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8gztqlv.fsf@hajtower \
    --to=haj@posteo.de \
    --cc=46302@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).