From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 46709@debbugs.gnu.org
Subject: bug#46709: 28.0.50; Emacs crash in gnutls_handshake
Date: Wed, 24 Feb 2021 18:08:33 +0100 [thread overview]
Message-ID: <87o8g95r72.fsf@gmail.com> (raw)
In-Reply-To: <87a6rt76ch.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2021 17:55:58 +0100")
>>>>> On Wed, 24 Feb 2021 17:55:58 +0100, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Robert Pluim <rpluim@gmail.com> writes:
>> My reading of
>> <https://gnutls.org/manual/gnutls.html#gnutls_005fhandshake> is that
>> after receiving a fatal error, we should not call gnutls_handshake
>> again. Iʼve tested the following patch successfully. We currently
>> check only for GNUTLS_E_INTERRUPTED, but the list of non-fatal error
>> codes is more than that, so perhaps more is needed.
>>
>> diff --git a/src/gnutls.c b/src/gnutls.c
>> index aa245ee5c3..4d5a909db0 100644
>> --- a/src/gnutls.c
>> +++ b/src/gnutls.c
>> @@ -625,6 +625,8 @@ gnutls_try_handshake (struct Lisp_Process *proc)
>>
>> while ((ret = gnutls_handshake (state)) < 0)
>> {
>> + if (gnutls_error_is_fatal (ret))
>> + return emacs_gnutls_handle_error (state, ret);
Lars> Yes, I think that this looks like the correct fix here.
Except now the test suite fails. Back to the drawing board.
Robert
next prev parent reply other threads:[~2021-02-24 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 18:35 bug#46709: 28.0.50; Emacs crash in gnutls_handshake Robert Pluim
2021-02-24 16:55 ` Lars Ingebrigtsen
2021-02-24 17:08 ` Robert Pluim [this message]
2021-02-24 18:23 ` Robert Pluim
2021-02-25 15:15 ` Lars Ingebrigtsen
2021-02-25 16:04 ` Robert Pluim
2021-02-25 18:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8g95r72.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=46709@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).