From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Date: Wed, 10 Mar 2021 15:54:30 +0100 Message-ID: <87o8frjbyx.fsf@gnus.org> References: <87h7lwmgaj.fsf@gnus.org> <874khj8v9c.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9166"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , 46819@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 10 15:58:58 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK0Ib-0002FT-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 15:58:57 +0100 Original-Received: from localhost ([::1]:47166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK0Ia-0003p2-3n for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 09:58:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK0En-0000jJ-Sz for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 09:55:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK0En-0006MX-LU for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 09:55:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lK0En-0000rv-KN for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 09:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 14:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46819 X-GNU-PR-Package: emacs Original-Received: via spool by 46819-submit@debbugs.gnu.org id=B46819.16153880843293 (code B ref 46819); Wed, 10 Mar 2021 14:55:01 +0000 Original-Received: (at 46819) by debbugs.gnu.org; 10 Mar 2021 14:54:44 +0000 Original-Received: from localhost ([127.0.0.1]:49489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0EW-0000r3-Kt for submit@debbugs.gnu.org; Wed, 10 Mar 2021 09:54:44 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:35330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0EU-0000qo-J8 for 46819@debbugs.gnu.org; Wed, 10 Mar 2021 09:54:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IlDqGcA0ehhHuRftktBPUrYITm8FzpW2rjzAlwR7UK4=; b=MC3eVhHiU+7oP+h3Cd1g3xi/sB ONuVXXnQOuryhmSAJp9deyXCzx9btw9e7cs5nymHFNVrtinxPn+RIA+wgFXcwtmNK1HbozQJLnJDz NILskNll1O4gE95AYkGojNkgIPjAFlsf2j/d4NQxyxBVYXuckshUXmN1GoYEmSN7PMRM=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK0EJ-0004S4-S1; Wed, 10 Mar 2021 15:54:35 +0100 X-Now-Playing: Siouxsie and the Banshees's _Join Hands_: "Regal Zone" In-Reply-To: <874khj8v9c.fsf@rfc20.org> (Matt Armstrong's message of "Tue, 09 Mar 2021 20:53:19 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201992 Archived-At: Matt Armstrong writes: > How about we fix benchmark's use of `let', and leave the warning in > place. It does not seem to be generating many other complaints, so it > may not be particularly annoying after all. I'm currently working with > `benchmark-run' a bunch and would like the warning gone from that one > use. > > I can make a patch, but a one liner might be quicker for one of you to > just commit directly. ;-) Yup; now done. I think we should keep the byte-compilation warning -- at least for now. If it leads to false positives all over the place, then perhaps not, but it's a useful warning, in my opinion. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no