From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47338: 28.0.50; Unexpected error in fill-region Date: Wed, 24 Mar 2021 10:24:48 +0100 Message-ID: <87o8f8ewf3.fsf@gnus.org> References: <83lfad7nk2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40748"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47338@debbugs.gnu.org, Evgeny Zajcev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 24 10:26:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOzmH-000AUx-8k for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Mar 2021 10:26:13 +0100 Original-Received: from localhost ([::1]:60698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOzmG-0005Qq-9u for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Mar 2021 05:26:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOzm6-0005OI-IH for bug-gnu-emacs@gnu.org; Wed, 24 Mar 2021 05:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOzm6-00059K-Aq for bug-gnu-emacs@gnu.org; Wed, 24 Mar 2021 05:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lOzm6-0007ja-6a for bug-gnu-emacs@gnu.org; Wed, 24 Mar 2021 05:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Mar 2021 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47338 X-GNU-PR-Package: emacs Original-Received: via spool by 47338-submit@debbugs.gnu.org id=B47338.161657790329642 (code B ref 47338); Wed, 24 Mar 2021 09:26:02 +0000 Original-Received: (at 47338) by debbugs.gnu.org; 24 Mar 2021 09:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:33959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOzl8-0007i1-Lq for submit@debbugs.gnu.org; Wed, 24 Mar 2021 05:25:02 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOzl6-0007hQ-9y for 47338@debbugs.gnu.org; Wed, 24 Mar 2021 05:25:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jb5Q9rmxNJp3pA1tI2IvMoWtnuaj/hT0gf0XHZp+WyE=; b=eDVyVB+0Lo4pAVVT4NLDuyijzh WXTe/F5GBzdGjKnYs2i8Hn7XE4VJmDSYBrhrVOIQLeKQv5NNRShLCcZ0MpEYUIrr8XjOSgodFlboF C9Zy3ccAYtt2qJhiZ+zeEyZkHmRAIwvG+oD0dAjWI7zGGympzBfrSiDLufJTUY4EaTtU=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOzkw-0007hc-37; Wed, 24 Mar 2021 10:24:53 +0100 X-Now-Playing: In The Nursery's _Twins_: "Profile 63" In-Reply-To: <83lfad7nk2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 23 Mar 2021 20:05:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202936 Archived-At: Eli Zaretskii writes: > This is the result of fixing bug#45720. In the above scenario, the > first time through the loop LINEBEG in the fragment below is set to > EOB+1 instead of the point where the fill-prefix ends: > > (let ((first t) > linebeg) > (while (< (point) to) > ;; On the first line, there may be text in the fill prefix > ;; zone. In that case, don't consider that area when > ;; trying to find a place to put a line break (bug#45720). > (if (not first) > (setq linebeg (point)) > (setq first nil > linebeg (+ (point) (length fill-prefix)))) <<<<<<<<<< > > CC'ing Lars who made that change. Right... the change tried to fix the case where there's a pre-computed fill prefix being passed in. In this bug, however, the prefix is computed, and this logic shouldn't be done here. I've now fixed this in Emacs 28, but I'm still not quite sure about the original fix... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no