From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#47879: [PATCH] Ignore mode hooks when analysing diffs Date: Sun, 18 Apr 2021 20:08:35 +0000 Message-ID: <87o8ebz77g.fsf@posteo.net> References: <878s5fpg1a.fsf@posteo.net> <837dkztmy0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47879@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 18 22:09:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYDjJ-0006Ug-AG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Apr 2021 22:09:17 +0200 Original-Received: from localhost ([::1]:48784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYDjI-0006ur-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Apr 2021 16:09:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYDj4-0006ug-LQ for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 16:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYDj4-00021r-7I for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 16:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYDj4-0002OD-2c for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 16:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Apr 2021 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47879-submit@debbugs.gnu.org id=B47879.16187765259161 (code B ref 47879); Sun, 18 Apr 2021 20:09:02 +0000 Original-Received: (at 47879) by debbugs.gnu.org; 18 Apr 2021 20:08:45 +0000 Original-Received: from localhost ([127.0.0.1]:47919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYDin-0002Nh-Db for submit@debbugs.gnu.org; Sun, 18 Apr 2021 16:08:45 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:37635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYDim-0002NU-9g for 47879@debbugs.gnu.org; Sun, 18 Apr 2021 16:08:44 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id C69F224002C for <47879@debbugs.gnu.org>; Sun, 18 Apr 2021 22:08:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618776518; bh=3PZA129o2Ce3zjKvQJMOia77GDlHEqfJjTUjQOd6SfI=; h=From:To:Cc:Subject:Date:From; b=nuiecJ6WdkVw3TdWuLpl4fe5TG7JbxFpE50VDbKvMG3gWBpqu1MDpM2wfLmq3sEAQ 5CVDikpgrR18vdlcwv8I4rlRm+QL9KFw4AmyYQNdAkgSO6KYvvV7QrEZUNydc0plUq IU1zOqdiBfT+kd+75ePyQxaGZaQTrnfl+fTZBjSdwq7EJ0uvyR06G49K1rYkxUvsQt ca+HTtedEjiiv3uvC4ZqxiZJNhRLLMOjIV5q9cc1cRKgVqeowiVlRPbF/12msDLTdw W9zBmJiK9Ya4XcWZ4Nl7P17x1qqc/DlHgO5dl5L9mqHN1fyQSK4w3wMx6Ik1aofkQ/ /E2ednCJY1XKg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FNgxd2TJTz6tmY; Sun, 18 Apr 2021 22:08:36 +0200 (CEST) In-Reply-To: <837dkztmy0.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Apr 2021 22:25:11 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204406 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Date: Sun, 18 Apr 2021 19:08:01 +0000 >> >> This fixes a bug related to log-edit-generate-changelog-from-diff. >> >> When I tried to invoke this command in a commit buffer, the error >> >> signal: Unmatched bracket or quote >> >> was raised. The reason was that I added paredit-mode to >> emacs-lisp-mode-hook, that when invoked calls check-parens. This raises >> an error when the diff contains a partial s-expression, which is almost >> always the case. >> >> The least invasive approach I could come up with was to defer the mode >> hooks. > > I rather think that the bug is either in the hook you added or in > paredit-mode, and should be solved there. Ok, I'll try that too. -- Philip K.