From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#47879: [PATCH] Ignore mode hooks when analysing diffs Date: Wed, 21 Apr 2021 14:36:22 +0000 Message-ID: <87o8e7aemx.fsf@posteo.net> References: <878s5fpg1a.fsf@posteo.net> <837dkztmy0.fsf@gnu.org> <87o8ebz77g.fsf@posteo.net> <83zgxrpvh2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27144"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47879@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 21 16:37:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZDyY-0006uu-9c for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 16:37:10 +0200 Original-Received: from localhost ([::1]:37064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZDyX-0006FA-De for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 10:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZDyQ-0006F1-3j for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZDyP-0003J5-Qo for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZDyP-00038C-ON for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 14:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47879-submit@debbugs.gnu.org id=B47879.161901579312001 (code B ref 47879); Wed, 21 Apr 2021 14:37:01 +0000 Original-Received: (at 47879) by debbugs.gnu.org; 21 Apr 2021 14:36:33 +0000 Original-Received: from localhost ([127.0.0.1]:59366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZDxx-00037U-6S for submit@debbugs.gnu.org; Wed, 21 Apr 2021 10:36:33 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:45555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZDxu-00037E-U4 for 47879@debbugs.gnu.org; Wed, 21 Apr 2021 10:36:31 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A9C312400FE for <47879@debbugs.gnu.org>; Wed, 21 Apr 2021 16:36:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1619015784; bh=Li++0ICoPcXuEoQRaDgZLG5wBiL0LnRJoFZidkg4wvg=; h=From:To:Cc:Subject:Date:From; b=kuO9sYYrAaQj3iIWD7vNGK/pQyJxjavbg/NNJuGY4lmqV70nRF2HBV1o3Woxu/ZO6 k1xSyIhAnk8lckKcPpVClzNXSYAwVbdidSG0wGvIBghQWunDMt1IgqcOZhlVvhfk7y QIdvu4ln9t8sdZ+7q4xTBGRgWJu34Jb6uZixibLAudtspPYSYfDWiTz1yWGiik9Bp9 LJTzxM9SqkL+6zvkWyP02GIMBCk1Zqb1CDXgsTG1C8lZweLoHaoNqKODccLpJc7188 zyMr3C+GhUICDtjWHg8oiyz4XL+mdrQsdzFcCqQyPHAIDVzKFjWYke70KCLMqX5tSf p6dbHoFJ8aqWw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FQNQv5CLKz6tmS; Wed, 21 Apr 2021 16:36:23 +0200 (CEST) In-Reply-To: <83zgxrpvh2.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 21 Apr 2021 17:23:37 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204621 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Wed, 21 Apr 2021 09:12:45 -0500 >> Cc: Eli Zaretskii , 47879@debbugs.gnu.org >> >> >> I rather think that the bug is either in the hook you added or in >> >> paredit-mode, and should be solved there. >> > >> > Ok, I'll try that too. >> >> So is this a notabug or a wontfix, or is there more to do here? > > Too early to say, I think. Let's give Philip some time to try to fix > it as I suggested. I looked into the code, and Philipp Stephani's suggestion to set paredit-override-check-parens-function to (lambda (_) t) seems to be the cleanest solution. I'd say this is not really a bug, but an issue in my configuration. It might be worth considering sending paredit a patch to only check the syntax if invoked interactively, but my suggestion was certainly too broad. -- Philip K.