From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: pillule Newsgroups: gmane.emacs.bugs Subject: bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter Date: Tue, 15 Jun 2021 21:50:03 +0200 Message-ID: <87o8c6525z.fsf@riseup.net> References: <878s3kzm66.fsf@riseup.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32948"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , 48916@debbugs.gnu.org, Juri Linkov To: pillule Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 15 22:01:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltFFK-0008Nn-U7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Jun 2021 22:01:15 +0200 Original-Received: from localhost ([::1]:50500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltFFJ-0003wS-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Jun 2021 16:01:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltFF8-0003td-8M for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 16:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltFF7-0005A4-WD for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 16:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ltFF7-0001tR-PM for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 16:01:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <878s3kzm66.fsf@riseup.net> Resent-From: pillule Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jun 2021 20:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48916-submit@debbugs.gnu.org id=B48916.16237872337234 (code B ref 48916); Tue, 15 Jun 2021 20:01:01 +0000 Original-Received: (at 48916) by debbugs.gnu.org; 15 Jun 2021 20:00:33 +0000 Original-Received: from localhost ([127.0.0.1]:50906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltFEe-0001sb-DW for submit@debbugs.gnu.org; Tue, 15 Jun 2021 16:00:33 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:42402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltFEb-0001sL-J5 for 48916@debbugs.gnu.org; Tue, 15 Jun 2021 16:00:30 -0400 Original-Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4G4K1M2SczzDsDk; Tue, 15 Jun 2021 13:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1623787224; bh=nqPPhkPrkNUyRem4P4U2Ah4MZ8C2ITerJyPtzQMlb/8=; h=From:To:Cc:Subject:Date:From; b=gMVrr6C8AjHnsLt8MbBeKyBrzpgPYpp1l6ayJBKaslnvJq7pf2ZmYCUSj23UFqhLG VU3lXaCjwXjboLSXX8R0WehS8IORFiHqQzIuTwku4gnPDoe4K+c7MLhjWRf5+9TV0C c6U32Fml/0wTFtGX34cH1yp9+wmvt639l3/1iRvE= X-Riseup-User-ID: B2A0E9BD6236C500226D00D9B73286CD64B64F4E96A812C89F24F1A1526DA167 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4G4K1J4bqzz5vY3; Tue, 15 Jun 2021 13:00:20 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208595 Archived-At: --=-=-= Content-Type: text/plain References: <878s3kzm66.fsf@riseup.net> <83czswfunl.fsf@gnu.org> <87zgw0xxya.fsf@riseup.net> <83y2bke98n.fsf@gnu.org> <878s3k76pe.fsf@gmail.com> <87mtryj28g.fsf@riseup.net> <87lf7ibxxf.fsf@mail.linkov.net> <87a6nyks9y.fsf@riseup.net> User-agent: mu4e 1.5.11; emacs 28.0.50 In-reply-to: <87a6nyks9y.fsf@riseup.net> pillule writes: > Juri Linkov writes: > >>> Should we --for these windmove-commands : >>> 1. keep them as they are >>> 2. make aliases and clean-up 'windmove-display-in-direction' >>> 3. delete them and clean-up 'windmove-display-in-direction' >>> ? >> >> Please keep them as they are. It's very convenient >> to bind these commands to use the same prefix keys >> that are configured by windmove customization >> (that was greatly improved recently!) > > Ok fine. Hi, here the patch for this one with v28.1 and an updated docstring. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0003-User-option-to-select-no-other-window-with-windmove-.patch Content-Description: user-option for no-other-window >From e1052bbfb919e9988b14a12e136dfebac86521f1 Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Tue, 8 Jun 2021 11:51:55 +0200 Subject: [PATCH] User-option to select 'no-other-window' with windmove (bug#48916) * lisp/windmove.el (windmove-wrap-around): Remove superfluous :group tag. (windmove-create-window): Remove superfluous :group tag. (windmove-window-distance-delta): Remove superfluous :group tag. (windmove-allow-all-windows): Add new user option to allow the commands of windmove to target windows with the 'no-other-window parameter. (windmove-find-other-window): Use windmove-allow-all-windows. (windmove-display-no-select): Remove superfluous :group tag. (windmove-display-in-direction): Use windmove-allow-all-windows. (windmove-delete-in-direction): Use windmove-allow-all-windows. (windmove-swap-states-in-direction): Use windmove-allow-all-windows. (windmove-default-keybindings): Remove superfluous :group tag. (windmove-display-default-keybindings): Remove superfluous :group tag. (windmove-delete-default-keybindings): Remove superfluous :group tag. (windmove-swap-states-default-keybindings): Remove superfluous :group tag. --- lisp/windmove.el | 41 +++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/lisp/windmove.el b/lisp/windmove.el index f558903681..3df4a01116 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -138,8 +138,7 @@ windmove-wrap-around a frame will find the rightmost one, and similarly for the other directions. The minibuffer is skipped over in up/down movements if it is inactive." - :type 'boolean - :group 'windmove) + :type 'boolean) (defcustom windmove-create-window nil "Whether movement off the edge of the frame creates a new window. @@ -147,7 +146,6 @@ windmove-create-window a frame will create a new window on the left, and similarly for the other directions." :type 'boolean - :group 'windmove :version "27.1") ;; If your Emacs sometimes places an empty column between two adjacent @@ -157,11 +155,18 @@ windmove-window-distance-delta Measured in characters either horizontally or vertically; setting this to a value larger than 1 may be useful in getting around window- placement bugs in old versions of Emacs." - :type 'number - :group 'windmove) + :type 'number) (make-obsolete-variable 'windmove-window-distance-delta "no longer used." "27.1") +(defcustom windmove-allow-all-windows nil + "Whether the windmove commands are allowed to target all type of windows. +If this variable is set to non-nil, all windmove commmands will +ignore the no-other-window parameter applied by `display-buffer-alist' +or `set-window-parameter'." + :type 'boolean + :version "28.1") + ;; Note: ;; @@ -342,7 +347,8 @@ windmove-find-other-window Optional ARG, if negative, means to use the right or bottom edge of WINDOW as reference position, instead of `window-point'; if positive, use the left or top edge of WINDOW as reference point." - (window-in-direction dir window nil arg windmove-wrap-around t)) + (window-in-direction dir window windmove-allow-all-windows + arg windmove-wrap-around t)) ;; Selects the window that's hopefully at the location returned by ;; `windmove-find-other-window', or screams if there's no window there. @@ -480,7 +486,6 @@ windmove-default-keybindings (defcustom windmove-display-no-select nil "Whether the window should be selected after displaying the buffer in it." :type 'boolean - :group 'windmove :version "27.1") (defun windmove-display-in-direction (dir &optional arg) @@ -517,7 +522,7 @@ windmove-display-in-direction ((eq dir 'same-window) (selected-window)) (t (window-in-direction - dir nil nil + dir nil windmove-allow-all-windows (and arg (prefix-numeric-value arg)) windmove-wrap-around 'nomini))))) (unless window @@ -606,8 +611,8 @@ windmove-delete-in-direction select the window at direction DIR. When `windmove-wrap-around' is non-nil, takes the window from the opposite side of the frame." - (let ((other-window (window-in-direction dir nil nil arg - windmove-wrap-around 'nomini))) + (let ((other-window (window-in-direction dir nil windmove-allow-all-windows + arg windmove-wrap-around 'nomini))) (cond ((null other-window) (user-error "No window %s from selected window" dir)) (t @@ -680,8 +685,8 @@ windmove-swap-states-in-direction "Swap the states of the selected window and the window at direction DIR. When `windmove-wrap-around' is non-nil, takes the window from the opposite side of the frame." - (let ((other-window (window-in-direction dir nil nil nil - windmove-wrap-around 'nomini))) + (let ((other-window (window-in-direction dir nil windmove-allow-all-windows + nil windmove-wrap-around 'nomini))) (cond ((or (null other-window) (window-minibuffer-p other-window)) (user-error "No window %s from selected window" dir)) (t @@ -761,8 +766,7 @@ windmove-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (defcustom windmove-display-default-keybindings nil "Default keybindings for windmove directional buffer display commands. @@ -780,8 +784,7 @@ windmove-display-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (defcustom windmove-delete-default-keybindings nil "Default keybindings for windmove directional window deletion commands. @@ -796,8 +799,7 @@ windmove-delete-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (defcustom windmove-swap-states-default-keybindings nil "Default keybindings for windmove's directional window swap-state commands. @@ -812,8 +814,7 @@ windmove-swap-states-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (provide 'windmove) -- 2.20.1 --=-=-= Content-Type: text/plain -- --=-=-=--