unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 22620@debbugs.gnu.org, Oleksandr Gavenko <gavenkoa@gmail.com>
Subject: bug#22620: 24.5; "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term", especially for "emacs -nw" (Emacs inside Emacs).
Date: Thu, 08 Jul 2021 03:25:06 +0200	[thread overview]
Message-ID: <87o8bdvbpp.fsf@gnus.org> (raw)
In-Reply-To: <87lfwkuog1.fsf_-_@gmail.com> (Noam Postavsky's message of "Fri,  26 Jul 2019 23:49:18 -0400")

Noam Postavsky <npostavs@gmail.com> writes:

> Oleksandr Gavenko <gavenkoa@gmail.com> writes:
>
>>   (global-hi-lock-mode 1)
>>
>> again broke "C-x" prefix.
>
> Yes, the problem is that hi-lock-mode defines keys using the C-x prefix,
> and it is a minor mode so it overrides term.el's major mode binding of
> C-x to term-send-raw.  It's not immediately clear to me what the correct
> fix is though.
>
> I guess we could add term-mode to hi-lock-exclude-modes?

Yup.  I did that in Emacs 28, and it made the problem go away.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2021-07-08  1:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 17:56 bug#22620: 24.5; "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term", especially for "emacs -nw" (Emacs inside Emacs) Oleksandr Gavenko
     [not found] ` <handler.22620.B.14551338951272.ack@debbugs.gnu.org>
2016-02-10 20:19   ` bug#22620: Acknowledgement (24.5; "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term", especially for "emacs -nw" (Emacs inside Emacs).) Oleksandr Gavenko
2019-07-27  3:49     ` bug#22620: 24.5; "(global-hi-lock-mode 1)" broke "C-x" key bindings inside "M-x term", especially for "emacs -nw" (Emacs inside Emacs) Noam Postavsky
2021-07-08  1:25       ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8bdvbpp.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=22620@debbugs.gnu.org \
    --cc=gavenkoa@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).