From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#49536: 28.0.50; Confusing dolist-with-progress-reporter behaviour Date: Tue, 13 Jul 2021 03:18:20 +0200 Message-ID: <87o8b7t3j7.fsf@web.de> References: <87bl77tulj.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49536@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 13 03:19:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m374n-000AQV-VG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 03:19:09 +0200 Original-Received: from localhost ([::1]:34498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m374m-0002nu-SP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Jul 2021 21:19:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m374g-0002nm-FB for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2021 21:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m374g-000253-7Y for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2021 21:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m374g-0007oW-0I for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2021 21:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jul 2021 01:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49536 X-GNU-PR-Package: emacs Original-Received: via spool by 49536-submit@debbugs.gnu.org id=B49536.162613911430001 (code B ref 49536); Tue, 13 Jul 2021 01:19:01 +0000 Original-Received: (at 49536) by debbugs.gnu.org; 13 Jul 2021 01:18:34 +0000 Original-Received: from localhost ([127.0.0.1]:39082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m374E-0007np-02 for submit@debbugs.gnu.org; Mon, 12 Jul 2021 21:18:34 -0400 Original-Received: from mout.web.de ([212.227.17.12]:38393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3748-0007nY-Id for 49536@debbugs.gnu.org; Mon, 12 Jul 2021 21:18:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1626139101; bh=vq2qFu9LzugHUki4ZrLEk51w8AstDgWJI/lvupQfyDw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=RCu266hSFwKDiUMbF3Tjc5XAhYooty7nymVqSTMoGHoJNnTTKJL6uOBgWy4Fe76ho LMkG9g5s11qhwQ4sQKzgHHEwPFuVoPUEN+otSKDgY+lWYDHQLz+rmzYyHpa7zmLf1m BspaySXs3QrsN+Ok6QpgAobb9B8eTUQwzdWuOpDg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MejmG-1lneZZ2Q8G-00ODux; Tue, 13 Jul 2021 03:18:21 +0200 In-Reply-To: <87bl77tulj.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 12 Jul 2021 15:33:44 +0000") X-Provags-ID: V03:K1:XP8PffjFIUNJU3c/2AjbanLDOWZjFxrKWb0sXyJkPUbcsFSxTrT Pd3Mq5UgtRMVQhIO0voJPTmE0GLfFKyjZwqVygksB18dSUKZVAo2ecFcIOTUChNVFlEC46g hyqc3TZ3pQQmG1U/mpgNdkvSK73if3lVaBfEbmRDazzls3FoMl4OhwIwYeKvpOSES/GPpKd g9fgiILTgt8y4bHnqxbmA== X-UI-Out-Filterresults: notjunk:1;V03:K0:wLJY7WLO9UI=:EBI2iZXLVi4SudqV8Rx0of 9aSEhlxMTcsY5ERZ0mhZA/Fj6DGhDaBG+npWVkbguVksB8uXj1D5hDvT/KKJ07XqXrJgXpGI0 HlEhE4RckMoZkwzGZjzO0B5ebqLV6YDpyU35jzu8LX2H3Muar4XUhYsz531A4i00nwXpAj2SE 9Mdle+Y8Teod2Pziy9Ljy5kC/ZZlz5JoYJRoeJ3/W5qFHv/NBYncfWBB4i2Ic4UbvtOvF10gX i7jxW2rsLcBVWeemgmPh5qxVbI3DzBvOSOCTwvXiRRvFKJac80rTDcytGpn11RwtN3Nkf19B/ lFK8g+fYYgDRV6bhC+rrN9UVpty3CetdqAPvjIyEpVf2fGLjGc3Lg02XQPyRkZhgqdD+IqJH8 uyeC7qyH17XhHSjE4fJz2DllJoO6Y5f4tRY7WRipvq2FD46+qIv82hOEntdt+5BDM6ol878aS r5d0/xQ+u6+Nso+X7Wll2bFF4CgCM8Ihi4k5ALvtUG417IV1njM9NYvZQgpSaS3Ni/j4Ohex/ qT0DWrRnM7Bhe9DrojoF5t+7xM3PHDt/RvQ4uW7wcqQmXpedzHaRAX4UdPiLlawA/sJgYKBT3 NP5TAUMqdSSxD9owncU9/Y5yToCVjolNBRcTSMUf7YsSvrWhiEbbILaYojxwjaa2RsCuOQts/ hggoincgBer+FzoiFoa+wwx0prX6y/styYc2YaSBkcQFw2eJNUuX3Wdpza7gwmxWp0FOlhuc1 w6XFAS3Hn7WNWK+Opz9mg166awRW1ofeItKCcNIGpIqPDWgJJEmA5S9HmP5cd8TupbXAlklT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209841 Archived-At: Philip Kaludercic writes: > I am not sure if this is intentional Looks more like a typical problem with counting... > but in case it is no, the following patch should fix it: > > From f7da2585886bd4fd795713a605ff6bd17a4c337a Mon Sep 17 00:00:00 2001 > From: Philip Kaludercic > Date: Mon, 12 Jul 2021 17:26:43 +0200 > Subject: [PATCH] Fix dolist-with-progress-reporter behaviour > > * subr.el (dolist-with-progress-reporter): Use the length of list > argument as maximal value the reporter with reach > --- > lisp/subr.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/subr.el b/lisp/subr.el > index e49c277335..20f40be40d 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -5880,7 +5880,7 @@ dolist-with-progress-reporter > (,count 0) > (,list ,(cadr spec))) > (when (stringp ,prep) > - (setq ,prep (make-progress-reporter ,prep 0 (1- (length ,list))))) > + (setq ,prep (make-progress-reporter ,prep 0 (length ,list)))) I think this patch is correct: 0 stands for 0% finished, and we have finished after processing 100% of the list's elements, whose number is (length list). With other words: we have (+ 1 (length list)) steps: one after having processed each element, plus the one before having started. Are you able to install the patch, or does someone else have to do it? Thanks, Michael.