From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#49848: 27.2.50; map-merge plist return alist Date: Thu, 05 Aug 2021 04:47:16 +0200 Message-ID: <87o8ac38wb.fsf@web.de> References: <87o8ae71yv.fsf@hm.sivalik.com> <877dh2qjf1.fsf@web.de> <877dh282io.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17669"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: rajeev.jnk@sivalik.com, 49848@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 05 04:48:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBTQY-0004Pt-PC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Aug 2021 04:48:10 +0200 Original-Received: from localhost ([::1]:56416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBTQW-00037h-PI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Aug 2021 22:48:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBTQQ-00037V-Dz for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 22:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBTQQ-0007RG-7w for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 22:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBTQQ-00024h-6K for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 22:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Aug 2021 02:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49848 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49848-submit@debbugs.gnu.org id=B49848.16281316567937 (code B ref 49848); Thu, 05 Aug 2021 02:48:02 +0000 Original-Received: (at 49848) by debbugs.gnu.org; 5 Aug 2021 02:47:36 +0000 Original-Received: from localhost ([127.0.0.1]:45515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBTQ0-00023x-Hp for submit@debbugs.gnu.org; Wed, 04 Aug 2021 22:47:36 -0400 Original-Received: from mout.web.de ([212.227.15.4]:46771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBTPy-00023S-KG for 49848@debbugs.gnu.org; Wed, 04 Aug 2021 22:47:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1628131637; bh=W+F1xjfqP4TTiU8yZ43AjoQiOxW9Z9aJIj2wc1sckT8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=idvOva59l/O+VIBHctTNA0C/5wzHhn/FSrji7AQzSBF8v11uq6yV7RGJfLWUTZiTB vkStsjUlcP6LqNmN12m+OqiupA6dOSXkNnGP/GBw488RgCM6d54IjUjM3X2lsLkd38 yfRpPBfxh0rJq/FFz9BuXqS4ujdb+qmgVPXuNQCw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lv7eE-1nAcq72J6o-010Ipe; Thu, 05 Aug 2021 04:47:17 +0200 In-Reply-To: <877dh282io.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 04 Aug 2021 01:41:35 +0100") X-Provags-ID: V03:K1:fpkMsVPjlwrnVV1R68I1UFW+nawDQxyFxtDuCGONUHDHe2Ck5rR C9CbQMqFhT9NdXQ/byEoq/YrY1d8lRLWYpyr+TkHEBRRAiq+NDoJt0t1RpJ6acfKOy1EtVZ GHzl9mgyB2G1TtBlGkyKc84uDoy71UYj1sZ6VCwm1BBUXsuIKyagKgWyVDufnKCAt/jUyAC l7SSIx++lwpE64RYasLvQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ll6Nw8n6ppI=:TYnpdb2hhENBGgBlX6Ar4b H4FDK+zU+jR82o9R03haXNHFVnBJiUuj3rxOyzA71bqqt5MfU+QM1f1sRBtzBGNvOtcQ0itzd c2ny9MGY/GaljvBJUwQ9DKjvSZUYdcm+cjOCeSbLCw/jAbK+IwEcj65DNHvSKlw3LMvetWYHk wDnNvzN/lqT9rTAJnsF9TjksKa74+EOLchZdbhv2mYASDj+jLbZBKkl0L7YJlJewvxA7me0Ak dngSfRAFjo4Pco0x961/UkwXBnccHsoj5qZ6dXz9e590kFuGAPmWwblrlE/bpaIjD+XhYhnOf 1He71S4Ep9J3co4RmzKTB8wRrmQcwzoHyl9lmsvQMMcDAvCXxbDsws9k8AlhebrJu5Z86+hFy eDX/k+Cgn1TZFc2xP6Lnbk5GJAEL+JnuLwBDbICGXiLpSxFwaF+ZCvzgS+N24LSPKuoqHhTMq 6TKNCJRQRO/qJYk6CCWLDQFuZVomZK6MjVuiI4HnSyxEBYoFTlL2vFRjYWum7PpSah01br+QY +6loVQacVjM2BKjDwZG8O6zxfCQlVOfG6heZwdikFOghABbP44mNE4+eWuVVk/6NHgqRXOLmW WBXpxR5byR1TJT9prnIfIpw/eI0S6yH1kSACSbq7zBe07uw9/N5mnkOWWLjLdK+UZ8Ufq34T7 OgCAzMZFd575QIHH742ZmD3Ii43TErK/uJGMi01K/7PKAHxx6esptaW7uoixxjwcNDbjVXFbV 4aL1lqYFyDcmGfLF2xJTg4uN9dph7RQcXsLau0qZK7PK19kcyVQdMYMJ095L9i5fx3rBAQJb X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211196 Archived-At: "Basil L. Contovounesios" writes: > In the specific case of merging maps into a desired type, we can simply > be more careful in such ambiguous cases. The attached patch does that, > while also avoiding the quadratic lookup behaviour for lists. Looks good and appropriate to me (I could not read very carefully, though, I'm tired today and can have a second look tomorrow). Should we handle the corner case when zero maps get merged? > I think the latter option may facilitate the equal-ity consistency > being discussed in https://bug.gnu.org/47368. > > WDYT? Seems a good idea to me, too. Thanks, Michael.