From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Mon, 16 Aug 2021 13:31:58 +0200 Message-ID: <87o89xfwwh.fsf@gnus.org> References: <87pmufb3u0.fsf@mail.linkov.net> <87tujqoram.fsf@gnus.org> <871r6u66zm.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20638"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50067@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 16 13:33:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFarh-000599-MJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 13:33:13 +0200 Original-Received: from localhost ([::1]:57476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFarg-0003kw-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 07:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFarW-0003hh-Ma for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 07:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFarW-0003KW-EI for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 07:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFarW-0001i3-75 for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 07:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Aug 2021 11:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.16291135335344 (code B ref 50067); Mon, 16 Aug 2021 11:33:02 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 16 Aug 2021 11:32:13 +0000 Original-Received: from localhost ([127.0.0.1]:48645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFaqj-0001Nn-2g for submit@debbugs.gnu.org; Mon, 16 Aug 2021 07:32:13 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFaqg-0001HZ-AX for 50067@debbugs.gnu.org; Mon, 16 Aug 2021 07:32:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3rs8lyn6YNG66WMF9rg5d5Huq+D89TVnGBlFeLz1yac=; b=O3UizJW9c919qNeXT0AUZ0KWHy gdshduh6tjoi8wWrMsCMvq5CRFyRZdFpMAqj9WRjTrXTc/2VXiF1Id6lLZiYz158JVXOfF89PyU8J 3U5CqV7vYEE/ZOYQfvaMX+HTUpDZUQFgIEDuF8Uqt21hKJtC2Ee3vGL0OAYCPPA1PN5I=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFaqV-0004DI-5U; Mon, 16 Aug 2021 13:32:03 +0200 In-Reply-To: <871r6u66zm.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 15 Aug 2021 19:12:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211981 Archived-At: Juri Linkov writes: >> +(defun eww-context-menu (menu) >> [...] >> + (when (or (mouse-posn-property (event-start last-input-event) 'shr-url) >> + (mouse-posn-property (event-start last-input-event) 'image-url)) >> + (define-key menu [shr-mouse-browse-url-new-window] [...] > To get an event would be nice, but I see no way to do this. > The top function 'context-menu-map' is called by: > > `(menu-item ,(purecopy "Context Menu") ignore > :filter (lambda (_) (context-menu-map)))) > > that has no access to the event - an unused argument of lambda above > is just the binding that is 'ignore' in this case. Could just use `last-input-event', I guess? But that doesn't really give us anything better than what we have, so there's probably no point. >> I'm also wondering whether we should add a `context-menu' text property. > > As soon as such a need arises, a text property could be added as well. > But it seems currently much cleaner is to use a single context-menu > function for every mode. Right. I was thinking that it's pretty likely that all button-like things are going to grow a context menu, but we can add `context-menu' later if that turns out to be the case. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no