From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 27 Aug 2021 20:10:13 +0300 Organization: LINKOV.NET Message-ID: <87o89ieruy.fsf@mail.linkov.net> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11599"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 19:17:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJfTd-0002iW-N5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 19:17:13 +0200 Original-Received: from localhost ([::1]:50682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJfTc-0003nn-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 13:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJfSV-0002RA-8q for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 13:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJfSV-0006QK-1b for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 13:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJfSU-00051V-Ft for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 13:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.163008452617176 (code B ref 39452); Fri, 27 Aug 2021 17:16:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 27 Aug 2021 17:15:26 +0000 Original-Received: from localhost ([127.0.0.1]:52877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfRu-0004Sn-0Y for submit@debbugs.gnu.org; Fri, 27 Aug 2021 13:15:26 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:49273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfRs-0004Jk-Cf for 39452@debbugs.gnu.org; Fri, 27 Aug 2021 13:15:24 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id AC2C1100005; Fri, 27 Aug 2021 17:15:15 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Fri, 27 Aug 2021 15:51:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212831 Archived-At: >> - (vc-git-command nil 0 (vc-git--literal-pathspecs (list old new)) "mv" "-f" "--")) >> + (vc-git-command nil 0 (list old new) "mv" "-f" "--")) > > Looks like the proper fix, thanks. Feel free to push it right away, if > you like. Pushed now. I wonder how many git commands still remain broken and will go unnoticed to the release? Such as vc-git-delete-file and vc-git-mark-resolved, etc. > Would be great to add some test, though. vc-tests.el currently doesn't > exercise vc-rename-file at all. Indeed, covering all git commands will avoid the danger of breaking some commands.