From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#27229: eldoc wrong highlighting for "when" Date: Fri, 03 Sep 2021 10:31:19 +0200 Message-ID: <87o89a12nc.fsf@gnus.org> References: <87k0w6dg58.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36027"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , "Charles A. Roelli" , 27229@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 03 10:33:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM4dW-0009AB-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Sep 2021 10:33:22 +0200 Original-Received: from localhost ([::1]:46532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM4dV-0001rH-Ah for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Sep 2021 04:33:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM4cE-0008LG-2N for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 04:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mM4cD-0003X7-Qv for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 04:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mM4cD-0008Sb-O7 for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 04:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Sep 2021 08:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 27229-submit@debbugs.gnu.org id=B27229.163065789332468 (code B ref 27229); Fri, 03 Sep 2021 08:32:01 +0000 Original-Received: (at 27229) by debbugs.gnu.org; 3 Sep 2021 08:31:33 +0000 Original-Received: from localhost ([127.0.0.1]:42882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM4bk-0008Rc-Nm for submit@debbugs.gnu.org; Fri, 03 Sep 2021 04:31:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM4bi-0008RJ-9x for 27229@debbugs.gnu.org; Fri, 03 Sep 2021 04:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1H/m8fukbl0FylxwmVVywmpIbsLQwgTmATPWvMhhltY=; b=gqApSph7gIDwG6XlxZLIjb1qNY iEHh8ssO+GqheREI7ia4ORtvxyUzhvaj9xqRQTCWbPtgVbAknGy9Ou8XSl7eT+IoHYLfGAOvafP2c w4WFJcCcUbRpMpXkyNpsif/HJ3h5uEXEgpvQSw35Wgtlj8UzgEmZvcJKyA3HEjdUyal8=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM4bY-0000JB-EJ; Fri, 03 Sep 2021 10:31:23 +0200 In-Reply-To: <87k0w6dg58.fsf@web.de> (Michael Heerdegen's message of "Sun, 04 Oct 2020 01:49:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213340 Archived-At: Michael Heerdegen writes: >> > From emacs -q, type "(when x y z": COND is highlighted >> > instead of BODY. This is a regression from the behavior >> > of 24.5 (with eldoc-mode on). >> >> I can reproduce this on current master. > > Seems this code is the culprit (`elisp--highlight-function-argument'): > > | ;; Back to index 0 in ARG1 ARG2 ARG2 ARG3 etc... > | ;; like in `setq'. > | ((or (and (string-match-p "\\.\\.\\.\\'" argument) > | (string= argument (car (last args-lst)))) > | (and (string-match-p "\\.\\.\\.\\'" > | (substring args 1 (1- (length args)))) > | (= (length (remove "..." args-lst)) 2) > | (> index 1) (eq (logand index 1) 1))) > | (setq index 0)) > > In general, the problem is that "..." can have different meanings (it's > not clear which arguments have to be repeated), so this is not trivial > to fix I think. I wonder -- why is this defined like this, anyway? (defmacro when (cond &rest body) "If COND yields non-nil, do BODY, else return nil. When COND yields non-nil, eval BODY forms sequentially and return value of last one, or nil if there are none. \(fn COND BODY...)" (when COND &rest BODY) is the correct signature, isn't it? Removing the (fn ...) from the doc string makes eldoc do the correct thing. The commit message is helpful: commit 7f67eea000b0ba102dd86c2666041dc395137413 Author: Kim F. Storm AuthorDate: Sun Mar 18 00:44:24 2007 +0000 (when, unless): Doc fix. Anybody know what the point of the (fn...) here is? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no