From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el Date: Mon, 13 Sep 2021 19:03:19 +0100 Message-ID: <87o88w4al4.fsf@gmail.com> References: <87bl5hm5qj.fsf@gmail.com> <87y283536t.fsf@gmail.com> <41cd4854-d162-bc6c-900e-96a4245e2c59@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50244@debbugs.gnu.org, Philipp Stephani , Theodor Thornhill To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 20:04:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPqJu-0001nk-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 20:04:42 +0200 Original-Received: from localhost ([::1]:33950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPqJt-0007ay-HI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 14:04:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPqJG-00079Y-IO for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 14:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPqJG-000300-7A for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 14:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPqJF-0005Zy-Vy for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 14:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50244 X-GNU-PR-Package: emacs Original-Received: via spool by 50244-submit@debbugs.gnu.org id=B50244.163155620821404 (code B ref 50244); Mon, 13 Sep 2021 18:04:01 +0000 Original-Received: (at 50244) by debbugs.gnu.org; 13 Sep 2021 18:03:28 +0000 Original-Received: from localhost ([127.0.0.1]:46776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPqIi-0005ZA-7u for submit@debbugs.gnu.org; Mon, 13 Sep 2021 14:03:28 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:42683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPqIh-0005Yy-3N for 50244@debbugs.gnu.org; Mon, 13 Sep 2021 14:03:27 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id u19-20020a7bc053000000b002f8d045b2caso591011wmc.1 for <50244@debbugs.gnu.org>; Mon, 13 Sep 2021 11:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=OI7AsTXgyUet/acdZCyY3YvOzzclzzPTBcBrYGp+hGI=; b=PAcqGPVxLawanr9uMlIAeVjTxE17CtuAxSrYD305d2LvrqZ0/+XNHzOmbnjm0uFj1c y+YkIbTSV2cGSqgiWjHHitUdasdP+Kjm7mcBiFf1wqDSaJuQy6fo4TH4/EMRqOJuWw0r 2b1xS7If47Ov2D7x5NS56VggdQyLHLOEIi9esC52bG4kRQiqKrS3TrlVUf8V/V4ClEn3 ge49ZB5GOXaKRORBDAi2L8ODa9iAVUMo6n4iMIjGEABvnC7MVYUROjSQysyT7tbMEcZp RywKFgzeMD7hydNSjMtBwhz39+afKnzF+6kaDx3Xv1TBxPtBLoQQJbLf+cldpjH5cQ/p BaQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=OI7AsTXgyUet/acdZCyY3YvOzzclzzPTBcBrYGp+hGI=; b=SeOTDhPYlNuTCvYgHOHPaM4vXRkxHThznawUuwWI5E19ICC4REszy1quberqYT7OFv ahQe1FN4CLOmx5HX7bPFGGnY0VJcXnac2ROQ2v/t71cb2YzjDgsNKb2lu7eF5j4/2mWH 4O4eCSTGX9VVn/apO9poc5SF4ixUtber6hFutQ/xcsV6s7cRcCgTYpKyy3OnPKXx6gzp WSIusI8tGcDwDQPFdb2t0NnbLXa/0o9bsD3bvg6O22hYQ+fn/l7qS2olDCKGqy0WBu50 3n18gTkFF5nnJOT3BB4X7dYyX2RCT9luGU3MdyKbItVGXAijMD28wKCToZg69p2/Jznq etAA== X-Gm-Message-State: AOAM530WXVPUAuiz9CyOMKQ+Wpr5bcsG6ffiILG6t8OEjCMtdem1EnvK +h/woaR14+mPXKDJt3DHAog= X-Google-Smtp-Source: ABdhPJxKlo1mU5s6aa5o091c4I6rzN3CQMlAzDt96SSTbSfOV1QyyBHYkfSlfuPcAs0kdrPyMifr+A== X-Received: by 2002:a1c:ac07:: with SMTP id v7mr12252209wme.160.1631556201198; Mon, 13 Sep 2021 11:03:21 -0700 (PDT) Original-Received: from nadja (a83-132-177-247.cpe.netcabo.pt. [83.132.177.247]) by smtp.gmail.com with ESMTPSA id i27sm7375398wmb.40.2021.09.13.11.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 11:03:20 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 13 Sep 2021 07:48:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214247 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Mon, Sep 13, 2021 at 1:08 AM Dmitry Gutov wrote: > >> Or maybe you will have unique "show diagnostics" buffers for every >> project, to be invoked manually? > > This. But it doesn't seem impossible to make a global diagnostics > buffer for every project one has open. The main changes to flymake.el and its documentation are now ready to push. There are some bugs regarding sorting in the diagnostics listing, and the maybe order and length of columns needs rearranging, but these can be sorted out later. The only outstanding issue preventing me from landing this in main is that I need to bump project.el's version so that the new `project-buffers` API generic function becomes officially available to the new bumped flymake.el version. Dmitry is it OK for me to do so? Here's the trivial patch to project.el. I'm bumping the minor version becasue a new backward-compatible feature was added. I can bump whatever you prefer if you think it's more in-line with the versioning scheme you normally use. diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index ba95ed094e..a6e231b9d6 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1,7 +1,7 @@ ;;; project.el --- Operations on the current project -*- lexical-binding:= t; -*- =20 ;; Copyright (C) 2015-2021 Free Software Foundation, Inc. -;; Version: 0.6.1 +;; Version: 0.7.1 ;; Package-Requires: ((emacs "26.1") (xref "1.0.2")) =20 ;; This is a GNU ELPA :core package. Avoid using functionality that Another important aspect is that I haven't had a change to test this with Eglot, which was one of the main motivators behind this change. The reason is that I don't have easy access to a server which reports diagnostics project wide (I thought clangd did, but I was mistaken). So the only client of the new functionality is the flymake-cc non-LSP backend, for now. Theodor, now would be a good time for you to step in with changes to Eglot that use the new `flymake-list-only-diagnostics` experimental API in flymake.el. Likely, some adjustments will have to be made to both packages. Thanks, Jo=C3=A3o