From: Michael Albinus <michael.albinus@gmx.de>
To: Damien Merenne <dam@cosinux.org>
Cc: 50748@debbugs.gnu.org
Subject: bug#50748: Acknowledgement (28.0.50; tramp-sh.el uses mknod file p which is not available on macos)
Date: Sat, 25 Sep 2021 15:03:31 +0200 [thread overview]
Message-ID: <87o88g9598.fsf@gmx.de> (raw)
In-Reply-To: <CAAgrLvgqEpUzuAm7nkXvfJRZgvjHZhNkmyLNM+ZBfioN_6g53g@mail.gmail.com> (Damien Merenne's message of "Sat, 25 Sep 2021 07:44:36 +0000")
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
Damien Merenne <dam@cosinux.org> writes:
Hi Damien,
> Here it is, I also attached one with the stty command commented out
> for reference.
Nothing special in the traces, everything looks normal. So I would apply
the following patch, could you pls test?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 815 bytes --]
diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el
index 7f1a52fa93..81b99b7c3c 100644
--- a/lisp/net/tramp-sh.el
+++ b/lisp/net/tramp-sh.el
@@ -2938,7 +2938,11 @@ tramp-sh-handle-make-process
(process-put p 'remote-pid pid)
(tramp-set-connection-property p "remote-pid" pid))
;; Disable carriage return to newline translation.
- (when (memq connection-type '(nil pipe))
+ (when (and (memq connection-type '(nil pipe))
+ (not (string-match-p
+ "Darwin"
+ (tramp-get-connection-property
+ v "uname" ""))))
(tramp-send-command v "stty -icrnl"))
;; `tramp-maybe-open-connection' and
;; `tramp-send-command-and-read' could have
[-- Attachment #3: Type: text/plain, Size: 24 bytes --]
Best regards, Michael.
next prev parent reply other threads:[~2021-09-25 13:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 6:29 bug#50748: 28.0.50; tramp-sh.el uses mknod file p which is not available on macos Damien Merenne
2021-09-23 12:39 ` Michael Albinus
[not found] ` <handler.50748.B.163237864728905.ack@debbugs.gnu.org>
2021-09-23 13:50 ` bug#50748: Acknowledgement (28.0.50; tramp-sh.el uses mknod file p which is not available on macos) Damien Merenne
2021-09-23 14:58 ` Michael Albinus
[not found] ` <CAAgrLvgMO680ujXuycY9tOP_xmrWN=P_C39skKdM94DQBkRstw@mail.gmail.com>
[not found] ` <CAAgrLvjq6y18kwvv9gepL1XtcRk5_tF+e7DCCnJitg4L6XuMjQ@mail.gmail.com>
[not found] ` <87mto29eah.fsf@gmx.de>
[not found] ` <CAAgrLvj-dvjH7ntv7h2ggWMOpACZFaq1W2-O7Q_Sqsn1YuaO3Q@mail.gmail.com>
2021-09-24 16:59 ` Michael Albinus
[not found] ` <CAAgrLvgqEpUzuAm7nkXvfJRZgvjHZhNkmyLNM+ZBfioN_6g53g@mail.gmail.com>
2021-09-25 13:03 ` Michael Albinus [this message]
2021-09-26 8:42 ` Michael Albinus
2021-09-28 8:10 ` Damien Merenne
2021-09-28 9:36 ` Michael Albinus
2021-09-28 12:00 ` Damien Merenne
2021-09-28 14:06 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o88g9598.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=50748@debbugs.gnu.org \
--cc=dam@cosinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).