From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Peter =?UTF-8?Q?M=C3=BCnster?= Newsgroups: gmane.emacs.bugs Subject: bug#52200: 29.0.50; image-dired-cmd-create-standard-thumbnail-options Date: Tue, 30 Nov 2021 17:24:02 +0100 Message-ID: <87o861k3x9.fsf@a16n.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3165"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 52200@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 30 17:25:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms5wS-0000dk-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 17:25:16 +0100 Original-Received: from localhost ([::1]:55318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ms5wR-0002SY-SX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 11:25:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ms5wJ-0002SQ-6J for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 11:25:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ms5wE-00029R-9U for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 11:25:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ms5wE-0003BJ-3g for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 11:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Peter =?UTF-8?Q?M=C3=BCnster?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Nov 2021 16:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52200 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Emacs Bugs Original-Received: via spool by submit@debbugs.gnu.org id=B.163828945512144 (code B ref -1); Tue, 30 Nov 2021 16:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Nov 2021 16:24:15 +0000 Original-Received: from localhost ([127.0.0.1]:42236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms5vP-00039j-PG for submit@debbugs.gnu.org; Tue, 30 Nov 2021 11:24:15 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:56886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms5vO-00039a-W4 for submit@debbugs.gnu.org; Tue, 30 Nov 2021 11:24:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ms5vO-0002MU-3s for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 11:24:10 -0500 Original-Received: from server.a16n.net ([178.33.238.77]:38618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ms5vL-00022n-5r for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 11:24:08 -0500 Original-Received: from ws.localdomain (lfbn-ren-1-2050-95.w92-167.abo.wanadoo.fr [92.167.129.95]) by server.a16n.net (Postfix) with ESMTPSA id BFBA943E0536 for ; Tue, 30 Nov 2021 17:24:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1638289443; bh=a74GUQD/8xq8gufI8RNRDfctK4KONc2BXVrnBbVPNio=; h=From:To:Subject:Date; b=VDB1fMeOT8SyLGClKTodLpEEJUrzFHLdSq70TnFp02fAKfP9Fb5F6qlnXY3viTznL FMYW3qZ4qPbNzwiXkvDEu4dLGAGwPMiU05bZ8xriA78Sv3j5xdZaXZU+ny+5BdnmG2 vODNvh1MFkOPl/hXpazDNMLke9UiJObEd1QV5p0/wpnT2aNfhhQmqMdJ3RZeEhmgVs DRzyQfgsMO7gwGZRoEhAH6qHcKYh4r0k5dkDm28l7iU/LtXeSbZ/Ei781hxSOIuTKK Q7P+roOk9FX5fpv2+zjjtkqEzkDUNLf2VbOuefl8HqIUdWHI6vf/Rc/cPFodlwdn6Q y8juzMu9xPQSQ== Original-Received: by ws.localdomain (Postfix, from userid 1000) id 1EF9A20547; Tue, 30 Nov 2021 17:24:03 +0100 (CET) Received-SPF: pass client-ip=178.33.238.77; envelope-from=pm@a16n.net; helo=server.a16n.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221142 Archived-At: --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, I'm a bit confused about image-dired-cmd-create-standard-thumbnail-options: =2D It seems, that it's not used with pngcrush or pngnq, so this test is perhaps useless: (unless (or image-dired-cmd-pngcrush-program image-dired-cmd-pngnq-program) ... =2D If gm is used, then the "convert" command should be added. The attached patch works for me, but probably I'm missing something... =2D-=20 Peter --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=my.patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 47a44a4a60..159f6a3b97 100644 =2D-- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -302,19 +302,17 @@ image-dired-cmd-optipng-options :link '(url-link "man:optipng(1)")) =20 (defcustom image-dired-cmd-create-standard-thumbnail-options =2D (append '("-size" "%wx%h" "%f[0]") =2D (unless (or image-dired-cmd-pngcrush-program =2D image-dired-cmd-pngnq-program) =2D (list =2D "-set" "Thumb::MTime" "%m" =2D "-set" "Thumb::URI" "file://%f" =2D "-set" "Description" "Thumbnail of file://%f" =2D "-set" "Software" (emacs-version))) =2D '("-thumbnail" "%wx%h>" "png:%t")) + (let ((opts (list "-size" "%wx%h" "%f[0]" + "-set" "Thumb::MTime" "%m" + "-set" "Thumb::URI" "file://%f" + "-set" "Description" "Thumbnail of file://%f" + "-set" "Software" (emacs-version) + "-thumbnail" "%wx%h>" "png:%t"))) + (if (executable-find "gm") (cons "convert" opts) opts)) "Options for creating thumbnails according to the Thumbnail Managing Sta= ndard. Available format specifiers are the same as in `image-dired-cmd-create-thumbnail-options', with %m for file modification = time." =2D :version "26.1" + :version "29.1" :type '(repeat (string :tag "Argument"))) =20 (defcustom image-dired-cmd-rotate-original-program --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYaZQIgwccG1AYTE2bi5u ZXQACgkQOo4rb0Oxy2g4GACbBStorLQ/zxyHPFpZdkjW1aDSAoEAn3X++siPtEzP I76O0ZvUyqCs8pQN =2B5B -----END PGP SIGNATURE----- --==-=-=--